Bug 200286

Summary: Fix 64-bit vs 32-bit mismatch in LogArgument
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Web Template FrameworkAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, eric.carlson, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-07-30 16:22:41 PDT
LogArgument is a utility for converting scalars into strings. It has a number of versions of a toString() method that is specialized for each type and converts the value to a string in a manner appropriate for that type. However, the versions of toString() for "long long" and "unsigned long long" are actually declared to take an "long" or "unsigned long" as a parameter. This difference leads to a 64-bit vs 32-bit error on 32-bit systems. Fix this by specifying correct/matching types.
Attachments
Patch (3.26 KB, patch)
2019-07-30 16:25 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-07-30 16:22:58 PDT
<rdar://problem/53733671>
Keith Rollin
Comment 2 2019-07-30 16:25:28 PDT
Created attachment 375193 [details] Patch
WebKit Commit Bot
Comment 3 2019-07-31 09:13:39 PDT
Comment on attachment 375193 [details] Patch Clearing flags on attachment: 375193 Committed r248043: <https://trac.webkit.org/changeset/248043>
WebKit Commit Bot
Comment 4 2019-07-31 09:13:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.