Bug 200264

Summary: Unify basic-gestures.js and ui-helpers.js
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: fred.wang, megan_gardner, simon.fraser, thorton, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181681

Simon Fraser (smfr)
Reported 2019-07-29 19:06:35 PDT
It's crazy that we have both basic-gestures.js and basic-gestures.js which basically are trying to do the same thing. I think we should migrate everything in basic-gestures.js to basic-gestures.js and use UIHelper.foo everywhere.
Attachments
Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-07-29 19:07:19 PDT
This would be good cleanup to do soon.
Simon Fraser (smfr)
Comment 2 2019-07-29 19:08:50 PDT
LayoutTests % grep -ril basic-gestures\.js * editing/input/ios/rtl-keyboard-input-on-focus.html editing/selection/ios/select-text-after-changing-focus.html editing/selection/ios/clear-selection-after-tapping-on-element-with-no-click-handler.html editing/selection/ios/autoscroll-with-top-content-inset-2.html editing/selection/ios/selection-handles-in-iframe.html editing/selection/ios/persist-selection-after-tapping-on-element-with-mousedown-handler.html editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html editing/selection/ios/selection-handles-in-readonly-input.html editing/selection/ios/autoscroll-with-top-content-inset.html editing/selection/ios/selection-handle-clamping-in-iframe.html fast/viewport/ios/initial-scale-after-changing-view-scale.html fast/scrolling/ios/hit-testing-iframe-004.html fast/scrolling/ios/mixing-user-and-programmatic-scroll-005.html fast/scrolling/ios/fixed-inside-overflow-inside-iframe.html fast/scrolling/ios/scroll-iframe-002.html fast/scrolling/ios/scroll-iframe-003.html fast/scrolling/ios/mixing-user-and-programmatic-scroll-004.html fast/scrolling/ios/hit-testing-iframe-005.html fast/scrolling/ios/frame-scrolling-no.html fast/scrolling/ios/body-overflow-hidden-height-100-percent-keyboard.html fast/scrolling/ios/scroll-iframe-004.html fast/scrolling/ios/body-overflow-hidden-height-100-percent-zoomed-2.html fast/scrolling/ios/hit-testing-iframe-002.html fast/scrolling/ios/mixing-user-and-programmatic-scroll-003.html fast/scrolling/ios/mixing-user-and-programmatic-scroll-002.html fast/scrolling/ios/hit-testing-iframe-003.html fast/scrolling/ios/mixing-user-and-programmatic-scroll-001.html fast/scrolling/ios/body-overflow-hidden-height-100-percent-zoomed-1.html fast/scrolling/ios/hit-testing-iframe-001.html fast/scrolling/ios/body-overflow-hidden.html fast/scrolling/ios/hit-testing-iframe-006.html fast/scrolling/ios/body-overflow-hidden-frame.html fast/scrolling/ios/scroll-iframe-001.html fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html fast/events/watchos/double-tap-to-zoom-on-full-width-text.html fast/events/watchos/double-tap-to-zoom-with-large-text.html fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text.html fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html fast/events/touch/ios/double-tap-on-editable-content-for-selection.html fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-left-to-change-selected-text.html fast/events/touch/ios/double-tap-on-editable-and-noneditable.html fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html fast/events/touch/ios/long-press-on-editable-content-then-drag-right-to-change-selected-text.html fast/events/touch/ios/long-press-to-select-text.html fast/events/touch/ios/long-press-then-drag-to-select-text.html fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text.html fast/events/touch/ios/long-press-to-select-and-tap-to-clear.html fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text.html fast/events/touch/ios/visibility-hidden-nested-iframe-click.html fast/events/touch/ios/long-press-on-editable-content-then-drag-left-to-change-selected-text.html fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html fast/events/touch/ios/touch-handler-on-body-simple.html fast/events/touch/ios/visibility-hidden-iframe-click.html fast/events/touch/ios/content-observation/visibility-change-with-image-content.html fast/events/touch/ios/content-observation/tap-on-input-type-button-element.html fast/events/touch/ios/content-observation/visibility-change-on-touch-start-simple.html fast/events/touch/ios/content-observation/new-content-covers-tap-target.html fast/events/touch/ios/content-observation/remove-subframe-while-observing.html fast/events/touch/ios/content-observation/visibility-change-happens-on-timer-hops.html fast/events/touch/ios/content-observation/non-visible-becomes-visible-and-gains-new-renderer.html fast/events/touch/ios/content-observation/visibility-change-after-touch-end.html fast/events/touch/ios/content-observation/tap-on-input-type-button-element-with-async-clickable-change.html fast/events/touch/ios/content-observation/100ms-transition-on-touch-start.html fast/events/touch/ios/content-observation/visibility-change-happens-at-the-second-timer.html fast/events/touch/ios/content-observation/click-instead-of-hover-simple.html fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart.html fast/events/touch/ios/content-observation/10ms-delay-0ms-transition-on-touch-start.html fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition.html fast/events/touch/ios/content-observation/transition-on-touch-start-and-remove.html fast/events/touch/ios/content-observation/400ms-hover-intent.html fast/events/touch/ios/content-observation/animation-end-with-visiblity-change-crash.html fast/events/touch/ios/content-observation/visibility-change-is-max-height-change.html fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html fast/events/touch/ios/content-observation/stuck-with-hover-state.html fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove-with-transition.html fast/events/touch/ios/content-observation/style-recalc-schedule-and-force-relalc.html fast/events/touch/ios/content-observation/visible-content-gains-new-renderer.html fast/events/touch/ios/content-observation/move-content-from-offscreen.html fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented.html fast/events/touch/ios/content-observation/100ms-delay-10ms-transition-on-mousemove.html fast/events/touch/ios/content-observation/tap-on-input-looking-div-with-role.html fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start.html fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove.html fast/events/touch/ios/content-observation/non-visible-content-gains-new-renderer.html fast/events/touch/ios/content-observation/tap-on-input-type-text-element.html fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html fast/events/touch/ios/content-observation/10ms-delay-0ms-transition-on-mousemove.html fast/events/touch/ios/content-observation/100ms-delay-10ms-transition-on-mousemove-no-clickable.html fast/events/touch/ios/content-observation/tap-on-input-type-button-element-with-clickable-change.html fast/events/touch/ios/content-observation/hover-while-loading-subframe.html fast/events/touch/ios/content-observation/0ms-transition-on-touch-start.html fast/events/touch/ios/content-observation/350ms-hover-intent.html fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end.html fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove-with-opacity-and-left.html fast/events/touch/ios/content-observation/0ms-delay-0ms-transition-on-mousemove.html fast/events/touch/ios/content-observation/hover-when-style-change-is-async.html fast/events/touch/ios/content-observation/clickable-content-is-inside-a-container.html fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html fast/events/ios/click-event-and-display-contents.html fast/events/autoscroll-when-input-is-offscreen.html fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html fast/events/autoscroll-with-software-keyboard.html platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html platform/ipad/fast/forms/select-with-title.html platform/ipad/fast/forms/multiple-select-updates-renderer.html platform/ipad/fast/forms/select-form-run-twice.html scrollingcoordinator/ios/fixed-frame-overflow-swipe.html
Note You need to log in before you can comment on or make changes to this bug.