Bug 20023 – Failed assertion in PropertyNameArray.cpp

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[David Hansen]

Just run this little test:

ASSERTION FAILED: identifier == &UString::Rep::null || identifier == &UString::Rep::empty || identifier->identifierTable
(JavaScriptCore/kjs/PropertyNameArray.cpp:30 void KJS::PropertyNameArray::add(KJS::UString::Rep*))

#include <stdlib.h>
#include <stdbool.h>
#include <JavaScriptCore/JavaScript.h>

static bool
has_prop (JSContextRef jsCtx, JSObjectRef jsObj, JSStringRef jsName)
{
  if (JSStringIsEqualToUTF8CString (jsName, "fourtyTwo"))
    return true;

  return false;
}


static JSValueRef
get_prop (JSContextRef jsCtx, JSObjectRef jsObj,
          JSStringRef jsName, JSValueRef *jsExn)
{
  return JSValueMakeNumber (jsCtx, 42.0);
}

static void
get_prop_names (JSContextRef jsCtx, JSObjectRef jsObj,
                JSPropertyNameAccumulatorRef jsNames)
{
  JSStringRef jsStr = JSStringCreateWithUTF8CString ("fourtyTwo");

  JSPropertyNameAccumulatorAddName (jsNames, jsStr);
  JSStringRelease (jsStr);
}

int
main (void)
{
  JSClassDefinition  cdef = kJSClassDefinitionEmpty;
  JSClassRef         jsClass;
  JSGlobalContextRef jsCtx;
  JSStringRef        jsScript;

  jsScript = JSStringCreateWithUTF8CString ("var a = [];"
                                            "for (i in this) { a.push[i]; }");

  cdef.className        = "Foo";
  cdef.hasProperty      = has_prop;
  cdef.getProperty      = get_prop;
  cdef.getPropertyNames = get_prop_names;

  jsClass = JSClassCreate (&cdef);
  jsCtx   = JSGlobalContextCreate (jsClass);

  /* Boom!  */
  JSEvaluateScript (jsCtx, jsScript, NULL, NULL, 0, NULL);

  return EXIT_SUCCESS;
}

/*
  Local Variables:
  compile-command: "gcc -g -ggdb -O0 -W -Wall \
    `pkg-config --cflags --libs webkit-1.0`   \
    jsaccum.c -o jsaccum"
  End:
*/

[Alexey Proskuryakov]

Created attachment 22290 [details]
proposed fix

/me mutters something about the benefits of type safety

[Geoffrey Garen]

Comment on attachment 22290 [details]
proposed fix

To unit test this, you can add some of the code above to testapi.c.

[Alexey Proskuryakov]

Committed revision 35196.

Turns out that testapi already exercised this code path - it's just that no one ran it in a while.