Bug 200218

Summary: [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
Product: WebKit Reporter: Fujii Hironori <fujii>
Component: Tools / TestsAssignee: Fujii Hironori <fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, don.olmstead, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+

Fujii Hironori
Reported 2019-07-29 00:00:40 PDT
[Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window * Move the logic from WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL
Attachments
Patch (4.20 KB, patch)
2019-07-29 00:02 PDT, Fujii Hironori 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-07-29 00:02:52 PDT
Created attachment 375066 [details] Patch
Brent Fulgham
Comment 2 2019-07-29 10:42:04 PDT
Comment on attachment 375066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375066&action=review > Tools/MiniBrowser/win/MainWindow.cpp:442 > + url = L"http://" + url; http, or https? :-)
Alex Christensen
Comment 3 2019-07-29 10:51:42 PDT
Comment on attachment 375066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375066&action=review >> Tools/MiniBrowser/win/MainWindow.cpp:442 >> + url = L"http://" + url; > > http, or https? :-) You could be the first browser to default to https if you want. If people want the plaintext page, they can type in the protocol themselves.
Fujii Hironori
Comment 4 2019-07-29 18:36:24 PDT
Somewhat too early. After Mac port MiniBrowser will change, I'll change Windows port MiniBrowser.
Fujii Hironori
Comment 5 2019-07-29 18:48:00 PDT
Committed r247935: <https://trac.webkit.org/changeset/247935>
Radar WebKit Bug Importer
Comment 6 2019-07-29 18:48:18 PDT
<rdar://problem/53690116>
Note You need to log in before you can comment on or make changes to this bug.