Bug 200196

Summary: [JSC] Increment bytecode age only when SlotVisitor is first-visit
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch rmorisset: review+

Yusuke Suzuki
Reported 2019-07-27 02:58:23 PDT
[JSC] Increment bytecode age only when SlotVisitor is first-visit
Attachments
Patch (2.71 KB, patch)
2019-07-27 02:59 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2019-07-27 23:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.08 KB, patch)
2019-07-28 23:12 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.13 KB, patch)
2019-07-29 00:03 PDT, Yusuke Suzuki 		rmorisset: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-07-27 02:59:26 PDT
Created attachment 375028 [details] Patch
Yusuke Suzuki
Comment 2 2019-07-27 23:53:24 PDT
Created attachment 375040 [details] Patch
Yusuke Suzuki
Comment 3 2019-07-28 23:12:35 PDT
Created attachment 375063 [details] Patch
Yusuke Suzuki
Comment 4 2019-07-29 00:03:25 PDT
Created attachment 375067 [details] Patch
Robin Morisset
Comment 5 2019-07-29 12:58:06 PDT
Comment on attachment 375067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375067&action=review r=me > Source/JavaScriptCore/runtime/Options.h:201 > + v(bool, countParseTimes, false, Normal, "counts prase times") \ prase => parse > JSTests/stress/reparsing-unlinked-codeblock.js:27 > +shouldBe(second >= 3, true); // `hello`, `inner`, `world`. Another functions can be destroyed, so using >= here. Another => Other
Yusuke Suzuki
Comment 6 2019-07-29 15:27:03 PDT
Committed r247925: <https://trac.webkit.org/changeset/247925>
Radar WebKit Bug Importer
Comment 7 2019-07-29 15:28:20 PDT
<rdar://problem/53682466>
Note You need to log in before you can comment on or make changes to this bug.