Bug 200193

Summary:

[JSC] Emit write barrier after storing instead of before storing

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews115 for mac-highsierra	none
Patch	none
Patch	none
Patch	none
Patch	saam: review+

Description Yusuke Suzuki 2019-07-27 00:14:04 PDT

[JSC] Emit write barrier *after* storing

Comment 1 Yusuke Suzuki 2019-07-27 00:14:12 PDT

Created attachment 375018 [details]
Patch

Comment 2 Yusuke Suzuki 2019-07-27 00:35:48 PDT

Created attachment 375020 [details]
Patch

Comment 3 EWS Watchlist 2019-07-27 01:46:15 PDT

Comment on attachment 375020 [details]
Patch

Attachment 375020 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12820575

Number of test failures exceeded the failure limit.

Comment 4 EWS Watchlist 2019-07-27 01:46:16 PDT

Created attachment 375022 [details]
Archive of layout-test-results from ews115 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 5 Yusuke Suzuki 2019-07-27 02:55:39 PDT

Created attachment 375027 [details]
Patch

Comment 6 Yusuke Suzuki 2019-07-29 11:00:41 PDT

<rdar://53668603>

Comment 7 Yusuke Suzuki 2019-07-29 16:19:35 PDT

Created attachment 375120 [details]
Patch

WIP

Comment 8 Yusuke Suzuki 2019-07-29 16:53:47 PDT

Created attachment 375126 [details]
Patch

Comment 9 Yusuke Suzuki 2019-07-29 18:18:04 PDT

Created attachment 375133 [details]
Patch

Comment 10 Saam Barati 2019-07-30 17:01:28 PDT

Comment on attachment 375133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375133&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        I reviewed tricky GC-related code including visitChildren and manual writeBarrier, and I found that we have several problems about write-barriers.

about => with

Comment 11 Yusuke Suzuki 2019-07-30 18:23:45 PDT

Comment on attachment 375133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375133&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        I reviewed tricky GC-related code including visitChildren and manual writeBarrier, and I found that we have several problems about write-barriers.
> 
> about => with

Fixed. Thanks!

Comment 12 Yusuke Suzuki 2019-07-30 18:35:44 PDT

Committed r248027: <https://trac.webkit.org/changeset/248027>