Web Inspector: Timelines: Develop > Start Timeline Recording doesn't work when focused on a detached inspector window

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. close/"remove" the Timelines tab
3. detach Web Inspector
4. Develop > Start Timeline Recording
 => nothing happens (if the page is focused instead of the detached inspector window, the Timelines tab is re-"added" and works as expected)

[Radar WebKit Bug Importer]

<rdar://problem/53543008>

[Devin Rousso]

Created attachment 374920 [details]
Patch

[BJ Burg]

Comment on attachment 374920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374920&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:-115
> -- (void)showTimelines

This does appear to be dead code once we remove the Safari call and rely on togglePageProfiling instead.

> Source/WebKit/UIProcess/WebInspectorProxy.cpp:350
>      m_isProfilingPage = !m_isProfilingPage;

Is this flag flipping now unnecessary, since we'll get notification from WebProcess once it actually works? If recording fails to start for some reason, this would erroneously think the timeline recording is active when it is not.

[Devin Rousso]

Comment on attachment 374920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374920&action=review

>> Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:-115
>> -- (void)showTimelines
> 
> This does appear to be dead code once we remove the Safari call and rely on togglePageProfiling instead.

Yup!

>> Source/WebKit/UIProcess/WebInspectorProxy.cpp:350
>>      m_isProfilingPage = !m_isProfilingPage;
> 
> Is this flag flipping now unnecessary, since we'll get notification from WebProcess once it actually works? If recording fails to start for some reason, this would erroneously think the timeline recording is active when it is not.

Good point! =D

[Devin Rousso]

Created attachment 375442 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 375442 [details]
Patch

Clearing flags on attachment: 375442

Committed r248177: <https://trac.webkit.org/changeset/248177>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.