Bug 200113

Summary:

Web Inspector: Runtime: don't allow the domain to be disabled

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, rniwa, saam, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=200854

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-highsierra	none
Archive of layout-test-results from ews117 for mac-highsierra	none

Devin Rousso

Reported 2019-07-24 21:37:53 PDT

Attachments
Patch (12.47 KB, patch) 2019-08-12 16:46 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (14.31 KB, patch) 2019-08-12 17:28 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (14.32 KB, patch) 2019-08-12 17:34 PDT, Devin Rousso	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.39 MB, application/zip) 2019-08-12 18:17 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (3.03 MB, application/zip) 2019-08-12 19:27 PDT, EWS Watchlist	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-08-12 16:46:34 PDT

Created attachment 376104 [details] Patch

EWS Watchlist

Comment 2 2019-08-12 16:49:22 PDT Comment hidden (obsolete)

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

Devin Rousso

Comment 3 2019-08-12 17:28:01 PDT

Created attachment 376113 [details] Patch

Devin Rousso

Comment 4 2019-08-12 17:34:55 PDT

Created attachment 376116 [details] Patch

EWS Watchlist

Comment 5 2019-08-12 18:17:53 PDT

Comment on attachment 376116 [details] Patch Attachment 376116 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12900939 New failing tests: inspector/runtime/change-execution-context-identifier.html http/tests/inspector/dom/cross-domain-inspected-node-access.html inspector/runtime/saveResult.html inspector/protocol/inspector-backend-invocation-return-value.html

EWS Watchlist

Comment 6 2019-08-12 18:17:55 PDT

Created attachment 376121 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-08-12 19:27:38 PDT

Comment on attachment 376116 [details] Patch Attachment 376116 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12901094 New failing tests: inspector/runtime/change-execution-context-identifier.html http/tests/inspector/dom/cross-domain-inspected-node-access.html inspector/runtime/saveResult.html

EWS Watchlist

Comment 8 2019-08-12 19:27:40 PDT

Created attachment 376129 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 9 2019-08-17 00:12:42 PDT

See <https://webkit.org/b/200854> for explanation.

Note You need to log in before you can comment on or make changes to this bug.