Bug 20010 – [Qt] Add API access to scrolling

• Component: WebKit Qt
• Status: RESOLVED FIXED

[marcoil]

Right now it's not possible to control a frame's scroll offset from the public API if no scrollbars are present.

Directly managing the scrolling is necessary, for example, when using "native" (not internal) scrollbars or alternative scrolling interfaces.

[marcoil]

Created attachment 22248 [details]
Adds API control of a frame scroll offset for r35126

This is a first attempt at adding API support for scrolling.

I have an example QtLauncher that uses QAbstractScrollArea and "real" scrollbars instead of the internal ones at http://git.collabora.co.uk/?p=user/marcoil/webkit.git;a=shortlog;h=refs/heads/marcoil/qtscrollbars

[marcoil]

Created attachment 22474 [details]
Re-made the patch with simplified API, r35344

After some comments in #qtwebkit, I have remade the patch with the following changes:
- Renamed scrollBy to scroll, as in other Qt classes.
- Removed the main frame control from QWebPage, as it's redundant.

[Simon Hausmann]

Comment on attachment 22474 [details]
Re-made the patch with simplified API, r35344

Patch looks good. But when landing two _tiny_ fixes should be done:

1) There's a const missing before the QSize& in setScrollOffset

2) The documentation of scroll() needs a \since 4.5 tag

[Mark Rowe (bdash)]

Landed in r35397 with the two requested tweaks.