Bug 200096 – Unable to tap/double tap to open files/folders in Google Drive in Safari

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

<rdar://problem/52748552>

[alan]

Created attachment 374816 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374816 [details]
Patch

Clearing flags on attachment: 374816

Committed r247817: <https://trac.webkit.org/changeset/247817>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

It looks like this change broke 14 http/tests/paymentrequest/ tests.

It looks like EWS caught this as well. 

Results page:
https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r247819%20(5376)/results.html

Can this be easily resolved? Otherwise I am going to roll this out shortly.

[alan]

(In reply to Truitt Savell from comment #4)
> It looks like this change broke 14 http/tests/paymentrequest/ tests.
> 
> It looks like EWS caught this as well. 
> 
> Results page:
> https://build.webkit.org/results/
> Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r247819%20(5376)/
> results.html
> 
> Can this be easily resolved? Otherwise I am going to roll this out shortly.
No idea why payment requests would fail due to double taps. Roll it out, please.

[Truitt Savell]

Reverted r247817 for reason:

Broke 14 http/tests/paymentrequest/ tests. on iOS

Committed r247820: <https://trac.webkit.org/changeset/247820>

[alan]

Created attachment 374935 [details]
Patch

[alan]

Created attachment 374937 [details]
Patch

[alan]

(In reply to zalan from comment #5)
> (In reply to Truitt Savell from comment #4)
> > It looks like this change broke 14 http/tests/paymentrequest/ tests.
> > 
> > It looks like EWS caught this as well. 
> > 
> > Results page:
> > https://build.webkit.org/results/
> > Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r247819%20(5376)/
> > results.html
> > 
> > Can this be easily resolved? Otherwise I am going to roll this out shortly.
> No idea why payment requests would fail due to double taps. Roll it out,
> please.
The payment tests trigger clicks on elements at speed like there's no tomorrow -> trigger double tap gesture.

[EWS Watchlist]

Comment on attachment 374937 [details]
Patch

Attachment 374937 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12813287

New failing tests:
http/tests/paymentrequest/payment-request-change-shipping-address.https.html
http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html
http/tests/paymentrequest/updateWith-method-pmi-handling.https.html
http/tests/paymentrequest/payment-response-complete-method.https.html
http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html
http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https.html
http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrorsV3.https.html
http/tests/paymentrequest/payment-request-abort-method.https.html
http/tests/paymentrequest/payment-response-payerName-attribute.https.html
http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
http/tests/paymentrequest/payment-request-change-shipping-option.https.html
http/tests/paymentrequest/payment-response-methodName-attribute.https.html
http/tests/paymentrequest/payment-response-retry-method.https.html
http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html
http/tests/paymentrequest/payment-request-show-method.https.html
http/tests/paymentrequest/payment-is-showing.https.html
http/tests/adClickAttribution/anchor-tag-attributes-validation.html
http/tests/ssl/applepay/PaymentRequest.https.html
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html
http/tests/paymentrequest/payment-request-merchant-validation.https.html
http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html
http/tests/paymentrequest/rejects_if_not_active.https.html
http/tests/ssl/applepay/ApplePaySessionFinalState.https.html
http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html
http/tests/ssl/applepay/ApplePayPaymentMethodChangeEvent.https.html
http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrors.https.html

[EWS Watchlist]

Created attachment 374946 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[alan]

Created attachment 374963 [details]
Patch

[alan]

(In reply to Build Bot from comment #10)
> Comment on attachment 374937 [details]
> Patch
> 
> Attachment 374937 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: https://webkit-queues.webkit.org/results/12813287
> 
> New failing tests:
> http/tests/paymentrequest/payment-request-change-shipping-address.https.html
> http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html
> http/tests/paymentrequest/updateWith-method-pmi-handling.https.html
> http/tests/paymentrequest/payment-response-complete-method.https.html
> http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html
> http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https.html
> http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrorsV3.https.html
> http/tests/paymentrequest/payment-request-abort-method.https.html
> http/tests/paymentrequest/payment-response-payerName-attribute.https.html
> http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html
> http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.
> html
> http/tests/paymentrequest/payment-request-change-shipping-option.https.html
> http/tests/paymentrequest/payment-response-methodName-attribute.https.html
> http/tests/paymentrequest/payment-response-retry-method.https.html
> http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html
> http/tests/paymentrequest/payment-request-show-method.https.html
> http/tests/paymentrequest/payment-is-showing.https.html
> http/tests/adClickAttribution/anchor-tag-attributes-validation.html
> http/tests/ssl/applepay/PaymentRequest.https.html
> http/tests/paymentrequest/payment-request-canmakepayment-method.https.html
> http/tests/paymentrequest/payment-request-merchant-validation.https.html
> http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html
> http/tests/paymentrequest/rejects_if_not_active.https.html
> http/tests/ssl/applepay/ApplePaySessionFinalState.https.html
> http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html
> http/tests/ssl/applepay/ApplePayPaymentMethodChangeEvent.https.html
> http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrors.https.html

guess I need to add the non-iOS version of (not exactly)activateElementAtHumanSpeed

[EWS Watchlist]

Comment on attachment 374963 [details]
Patch

Attachment 374963 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12816066

New failing tests:
http/tests/adClickAttribution/anchor-tag-attributes-validation.html

[EWS Watchlist]

Created attachment 374968 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[alan]

(In reply to Build Bot from comment #14)
> Comment on attachment 374963 [details]
> Patch
> 
> Attachment 374963 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: https://webkit-queues.webkit.org/results/12816066
> 
> New failing tests:
> http/tests/adClickAttribution/anchor-tag-attributes-validation.html
-CONSOLE MESSAGE: line 165: adcampaignid must have a non-negative value less than or equal to 63 for Ad Click Attribution.
-CONSOLE MESSAGE: line 165: adcampaignid must have a non-negative value less than or equal to 63 for Ad Click Attribution.
-CONSOLE MESSAGE: line 165: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
-CONSOLE MESSAGE: line 165: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
-CONSOLE MESSAGE: line 165: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
-CONSOLE MESSAGE: line 165: addestination could not be converted to a valid HTTP-family URL.
-CONSOLE MESSAGE: line 165: addestination could not be converted to a valid HTTP-family URL.
-CONSOLE MESSAGE: line 165: addestination could not be converted to a valid HTTP-family URL.
-CONSOLE MESSAGE: line 165: Both adcampaignid and addestination need to be set for Ad Click Attribution to work.
-CONSOLE MESSAGE: line 165: Both adcampaignid and addestination need to be set for Ad Click Attribution to work.
-CONSOLE MESSAGE: line 165: addestination can not be the same site as the current website.
+CONSOLE MESSAGE: line 192: adcampaignid must have a non-negative value less than or equal to 63 for Ad Click Attribution.
+CONSOLE MESSAGE: line 192: adcampaignid must have a non-negative value less than or equal to 63 for Ad Click Attribution.
+CONSOLE MESSAGE: line 192: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
+CONSOLE MESSAGE: line 192: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
+CONSOLE MESSAGE: line 192: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
+CONSOLE MESSAGE: line 192: addestination could not be converted to a valid HTTP-family URL.
+CONSOLE MESSAGE: line 192: addestination could not be converted to a valid HTTP-family URL.
+CONSOLE MESSAGE: line 192: addestination could not be converted to a valid HTTP-family URL.
+CONSOLE MESSAGE: line 192: Both adcampaignid and addestination need to be set for Ad Click Attribution to work.
+CONSOLE MESSAGE: line 192: Both adcampaignid and addestination need to be set for Ad Click Attribution to work.
+CONSOLE MESSAGE: line 192: addestination can not be the same site as the current website.

SRSLY?

[alan]

Created attachment 374969 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374969 [details]
Patch

Rejecting attachment 374969 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 374969, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/12816465

[alan]

Created attachment 374972 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374972 [details]
Patch

Clearing flags on attachment: 374972

Committed r247866: <https://trac.webkit.org/changeset/247866>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.