Bug 200085

Summary:	ASSERTION FAILED: !m_statisticsStore in WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore()
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	New Bugs	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=200071
Bug Depends on:
Bug Blocks:	200071

Ryan Haddad

Reported 2019-07-24 10:02:55 PDT

An API test is failing a new assertion added with https://trac.webkit.org/changeset/247766/webkit on macOS and iOS bots: TestWebKitAPI.ResourceLoadStatistics.NetworkProcessRestart ASSERTION FAILED: !m_statisticsStore /Volumes/Data/slave/highsierra-debug/build/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp(183) : WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore() 1 0x122995a49 WTFCrash 2 0x109618e6b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x109b6b9e7 WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore() 4 0x109b6bcb5 WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore() 5 0x109b264ba WTF::ThreadSafeRefCounted<WebKit::WebResourceLoadStatisticsStore, (WTF::DestructionThread)1>::deref() const::'lambda'()::operator()() const 6 0x109b26436 WTF::ThreadSafeRefCounted<WebKit::WebResourceLoadStatisticsStore, (WTF::DestructionThread)1>::deref() const 7 0x109b28761 void WTF::derefIfNotNull<WebKit::WebResourceLoadStatisticsStore>(WebKit::WebResourceLoadStatisticsStore*) 8 0x109afe977 WTF::RefPtr<WebKit::WebResourceLoadStatisticsStore, WTF::DumbPtrTraits<WebKit::WebResourceLoadStatisticsStore> >::operator=(std::nullptr_t) 9 0x109afe7d9 WebKit::NetworkSession::setResourceLoadStatisticsEnabled(bool) 10 0x109a453cd WebKit::NetworkProcess::setResourceLoadStatisticsEnabled(bool) 11 0x1097db432 void IPC::callMemberFunctionImpl<WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool), std::__1::tuple<bool>, 0ul>(WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool), std::__1::tuple<bool>&&, std::__1::integer_sequence<unsigned long, 0ul>) 12 0x1097db380 void IPC::callMemberFunction<WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool), std::__1::tuple<bool>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<bool>&&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool)) 13 0x1097b6571 void IPC::handleMessage<Messages::NetworkProcess::SetResourceLoadStatisticsEnabled, WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool)>(IPC::Decoder&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool)) 14 0x1097b0e76 WebKit::NetworkProcess::didReceiveNetworkProcessMessage(IPC::Connection&, IPC::Decoder&) 15 0x109a3d9a0 WebKit::NetworkProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 16 0x10968ecbc IPC::Connection::dispatchMessage(IPC::Decoder&) 17 0x109681091 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 18 0x10968fe17 IPC::Connection::dispatchOneIncomingMessage() 19 0x1096af3d8 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_11::operator()() 20 0x1096af2e9 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_11, void>::call() 21 0x1229bff9d WTF::Function<void ()>::operator()() const 22 0x122a22a23 WTF::RunLoop::performWork() 23 0x122a233d4 WTF::RunLoop::performWork(void*) 24 0x7fff53391581 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 25 0x7fff534498ac __CFRunLoopDoSource0 26 0x7fff53374530 __CFRunLoopDoSources0 27 0x7fff533739ad __CFRunLoopRun 28 0x7fff53373207 CFRunLoopRunSpecific 29 0x7fff5548be76 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 30 0x7fff5548bd4e -[NSRunLoop(NSRunLoop) run] 31 0x7fff7b67cd4b _xpc_objc_main ASSERTION FAILED: !m_statisticsStore /Volumes/Data/slave/highsierra-debug/build/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp(183) : WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore() 1 0x120230a49 WTFCrash 2 0x106eb3e6b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1074069e7 WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore() 4 0x107406cb5 WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore() 5 0x1073c14ba WTF::ThreadSafeRefCounted<WebKit::WebResourceLoadStatisticsStore, (WTF::DestructionThread)1>::deref() const::'lambda'()::operator()() const 6 0x1073c1436 WTF::ThreadSafeRefCounted<WebKit::WebResourceLoadStatisticsStore, (WTF::DestructionThread)1>::deref() const 7 0x1073c3761 void WTF::derefIfNotNull<WebKit::WebResourceLoadStatisticsStore>(WebKit::WebResourceLoadStatisticsStore*) 8 0x107399977 WTF::RefPtr<WebKit::WebResourceLoadStatisticsStore, WTF::DumbPtrTraits<WebKit::WebResourceLoadStatisticsStore> >::operator=(std::nullptr_t) 9 0x1073997d9 WebKit::NetworkSession::setResourceLoadStatisticsEnabled(bool) 10 0x1072e03cd WebKit::NetworkProcess::setResourceLoadStatisticsEnabled(bool) 11 0x107076432 void IPC::callMemberFunctionImpl<WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool), std::__1::tuple<bool>, 0ul>(WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool), std::__1::tuple<bool>&&, std::__1::integer_sequence<unsigned long, 0ul>) 12 0x107076380 void IPC::callMemberFunction<WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool), std::__1::tuple<bool>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<bool>&&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool)) 13 0x107051571 void IPC::handleMessage<Messages::NetworkProcess::SetResourceLoadStatisticsEnabled, WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool)>(IPC::Decoder&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool)) 14 0x10704be76 WebKit::NetworkProcess::didReceiveNetworkProcessMessage(IPC::Connection&, IPC::Decoder&) 15 0x1072d89a0 WebKit::NetworkProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 16 0x106f29cbc IPC::Connection::dispatchMessage(IPC::Decoder&) 17 0x106f1c091 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 18 0x106f2ae17 IPC::Connection::dispatchOneIncomingMessage() 19 0x106f4a3d8 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_11::operator()() 20 0x106f4a2e9 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_11, void>::call() 21 0x12025af9d WTF::Function<void ()>::operator()() const 22 0x1202bda23 WTF::RunLoop::performWork() 23 0x1202be3d4 WTF::RunLoop::performWork(void*) 24 0x7fff53391581 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 25 0x7fff534498ac __CFRunLoopDoSource0 26 0x7fff53374530 __CFRunLoopDoSources0 27 0x7fff533739ad __CFRunLoopRun 28 0x7fff53373207 CFRunLoopRunSpecific 29 0x7fff5548be76 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 30 0x7fff5548bd4e -[NSRunLoop(NSRunLoop) run] 31 0x7fff7b67cd4b _xpc_objc_main LEAK: 1 WebProcessPool https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20(Tests)/builds/3730 https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/builds/4758

Attachments
Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-07-24 10:10:40 PDT

<https://trac.webkit.org/changeset/247769>

Radar WebKit Bug Importer

Comment 2 2019-07-24 10:13:50 PDT

<rdar://problem/53501878>

Note You need to log in before you can comment on or make changes to this bug.