Bug 200065

Summary:

REGRESSION(r241288): Text on Yahoo Japan mobile looks too bold

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, cdumez, cmarcelo, dbates, dino, ews-watchlist, jonlee, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

200047

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	simon.fraser: review+

Myles C. Maxfield

Reported 2019-07-23 17:25:12 PDT

REGRESSION(r241288): Text on Yahoo Japan mobile looks too bold

Attachments
Patch (7.88 KB, patch) 2019-07-23 17:34 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (9.05 KB, patch) 2019-07-29 19:18 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (9.08 KB, patch) 2019-07-29 20:58 PDT, Myles C. Maxfield	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2019-07-23 17:34:40 PDT

Created attachment 374741 [details] Patch

Myles C. Maxfield

Comment 2 2019-07-23 17:34:43 PDT

<rdar://problem/50912757>

Simon Fraser (smfr)

Comment 3 2019-07-23 19:08:42 PDT

Comment on attachment 374741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374741&action=review > Source/WTF/wtf/Platform.h:1619 > +#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 60000) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000) > +#define USE_HIRAGINO_SANS_WORKAROUND 1 > +#endif Seems wrong for something so specific to be in Platform.h > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1156 > + // This is yucky code, but it's necessary for yahoo.co.jp. > + // FIXME: https://bugs.webkit.org/show_bug.cgi?id=200047 Remove this code. Should this then be a Quirk?

Alexey Proskuryakov

Comment 4 2019-07-23 23:09:45 PDT

> Seems wrong for something so specific to be in Platform.h What would you suggest? My understanding is that Platform.h is exactly where such things need to be. Seems like we want to be checking for PLATFORM(IOS) not PLATFORM(IOS_FAMILY) here.

Simon Fraser (smfr)

Comment 5 2019-07-24 11:15:59 PDT

Comment on attachment 374741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374741&action=review >> Source/WTF/wtf/Platform.h:1619 >> +#endif > > Seems wrong for something so specific to be in Platform.h Would this stay in the tree in perpetuity? When would we know that we can remove it?

Myles C. Maxfield

Comment 6 2019-07-29 12:03:01 PDT

Hooking this up to a quirk appears to be fairly difficult, since control flows through a singleton FontDatabase object which owns all the CTFonts. Instead, I'll try to modify the request rather than modify the font object.

Myles C. Maxfield

Comment 7 2019-07-29 19:18:13 PDT

Created attachment 375139 [details] Patch

Myles C. Maxfield

Comment 8 2019-07-29 20:58:06 PDT

Created attachment 375144 [details] Patch

Simon Fraser (smfr)

Comment 9 2019-07-30 11:20:59 PDT

Comment on attachment 375144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375144&action=review > Source/WebCore/page/Quirks.cpp:396 > + // FIXME: https://bugs.webkit.org/show_bug.cgi?id=200047 Remove this quirk. Nicer to use webkit.org/b/200047

Myles C. Maxfield

Comment 10 2019-07-30 14:48:34 PDT

Committed r248018: <https://trac.webkit.org/changeset/248018>

Note You need to log in before you can comment on or make changes to this bug.