Bug 200063

Summary: [WHLSL] Use bmalloc instead of system malloc for WHLSL data structures
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, ggaren, jonlee, justin_fan, mmaxfield, rmorisset, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
sam: review+
patch for landing none

Saam Barati
Reported 2019-07-23 17:11:21 PDT
It's 30-40% faster in WHLSL::prepare on some tests.
Attachments
patch (56.23 KB, patch)
2019-07-23 18:19 PDT, Saam Barati 		sam: review+
DetailsFormatted DiffDiff
patch for landing (56.40 KB, patch)
2019-07-24 13:11 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-07-23 18:19:49 PDT
Created attachment 374749 [details] patch
Saam Barati
Comment 2 2019-07-23 18:42:36 PDT
Comment on attachment 374749 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=374749&action=review > Source/WebCore/ChangeLog:8 > + This is a 25-30% WHLSL compile time speedup on Justin's textured-cube demo. the hello-cube.html demo seems to get close to 40% faster in the WHLSL compiler
Saam Barati
Comment 3 2019-07-23 18:47:43 PDT
Comment on attachment 374749 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=374749&action=review >> Source/WebCore/ChangeLog:8 >> + This is a 25-30% WHLSL compile time speedup on Justin's textured-cube demo. > > the hello-cube.html demo seems to get close to 40% faster in the WHLSL compiler The phases most positively impacted are: Checker includeStandardLibrary autoInitializeVariables resolveProperties (I'll add this to the changelog)
Sam Weinig
Comment 4 2019-07-23 19:15:44 PDT
Comment on attachment 374749 [details] patch rs=me
Saam Barati
Comment 5 2019-07-24 13:11:32 PDT
Created attachment 374796 [details] patch for landing
WebKit Commit Bot
Comment 6 2019-07-24 19:40:13 PDT
Comment on attachment 374796 [details] patch for landing Clearing flags on attachment: 374796 Committed r247813: <https://trac.webkit.org/changeset/247813>
WebKit Commit Bot
Comment 7 2019-07-24 19:40:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-07-24 19:43:17 PDT
<rdar://problem/53524937>
Note You need to log in before you can comment on or make changes to this bug.