Bug 200059

Summary: [Timeline]: Make timeline header width automatic, instead of fixed width
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbedard, ryanhaddad, tsavell, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Zhifei Fang 2019-07-23 16:34:30 PDT
<rdar://problem/53470453>
Comment 1 Zhifei Fang 2019-07-23 16:44:54 PDT
Created attachment 374733 [details]
Patch
Comment 2 Jonathan Bedard 2019-07-24 10:15:48 PDT
Not sure this actually does what we expect it to, because of <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers to still scroll? Because the do still scroll with this change.
Comment 3 Zhifei Fang 2019-07-24 10:21:02 PDT
(In reply to Jonathan Bedard from comment #2)
> Not sure this actually does what we expect it to, because of
> <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers
> to still scroll? Because the do still scroll with this change.

The header will not be scrolled anymore, it will use the longest text as its width, then the timeline will use up what the remains.
Comment 4 Jonathan Bedard 2019-07-24 13:34:59 PDT
(In reply to Zhifei Fang from comment #3)
> (In reply to Jonathan Bedard from comment #2)
> > Not sure this actually does what we expect it to, because of
> > <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers
> > to still scroll? Because the do still scroll with this change.
> 
> The header will not be scrolled anymore, it will use the longest text as its
> width, then the timeline will use up what the remains.

Do some more testing locally, because at the moment, it definitely doesn't do that at the moment.
Comment 5 Zhifei Fang 2019-07-24 14:40:35 PDT
(In reply to Jonathan Bedard from comment #4)
> (In reply to Zhifei Fang from comment #3)
> > (In reply to Jonathan Bedard from comment #2)
> > > Not sure this actually does what we expect it to, because of
> > > <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers
> > > to still scroll? Because the do still scroll with this change.
> > 
> > The header will not be scrolled anymore, it will use the longest text as its
> > width, then the timeline will use up what the remains.
> 
> Do some more testing locally, because at the moment, it definitely doesn't
> do that at the moment.

I found I haven't deployed it, will try again.
Comment 6 Zhifei Fang 2019-07-24 14:59:39 PDT
Created attachment 374815 [details]
Patch
Comment 7 Zhifei Fang 2019-07-24 15:00:37 PDT
(In reply to Zhifei Fang from comment #6)
> Created attachment 374815 [details]
> Patch

Deployed, I found I also need to delete those customized styles.
Comment 8 Jonathan Bedard 2019-07-25 08:44:00 PDT
Before we land, I'd like to run the change by bot watchers to make sure they like the difference.
Comment 9 Truitt Savell 2019-07-25 08:56:04 PDT
The fixed width of the names feels solid to me and is definitely more readable.
Comment 10 Jonathan Bedard 2019-07-25 08:56:41 PDT
(In reply to Truitt Savell from comment #9)
> The fixed width of the names feels solid to me and is definitely more
> readable.

Ok! r+ed then!
Comment 11 WebKit Commit Bot 2019-07-25 11:16:40 PDT
Comment on attachment 374815 [details]
Patch

Clearing flags on attachment: 374815

Committed r247830: <https://trac.webkit.org/changeset/247830>
Comment 12 WebKit Commit Bot 2019-07-25 11:16:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2019-07-25 11:17:23 PDT
<rdar://problem/53550660>