Summary: | [Timeline]: Make timeline header width automatic, instead of fixed width | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zhifei Fang <zhifei_fang> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jbedard, ryanhaddad, tsavell, webkit-bug-importer, zhifei_fang | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari Technology Preview | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Zhifei Fang
2019-07-23 16:34:30 PDT
Created attachment 374733 [details]
Patch
Not sure this actually does what we expect it to, because of <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers to still scroll? Because the do still scroll with this change. (In reply to Jonathan Bedard from comment #2) > Not sure this actually does what we expect it to, because of > <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers > to still scroll? Because the do still scroll with this change. The header will not be scrolled anymore, it will use the longest text as its width, then the timeline will use up what the remains. (In reply to Zhifei Fang from comment #3) > (In reply to Jonathan Bedard from comment #2) > > Not sure this actually does what we expect it to, because of > > <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers > > to still scroll? Because the do still scroll with this change. > > The header will not be scrolled anymore, it will use the longest text as its > width, then the timeline will use up what the remains. Do some more testing locally, because at the moment, it definitely doesn't do that at the moment. (In reply to Jonathan Bedard from comment #4) > (In reply to Zhifei Fang from comment #3) > > (In reply to Jonathan Bedard from comment #2) > > > Not sure this actually does what we expect it to, because of > > > <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers > > > to still scroll? Because the do still scroll with this change. > > > > The header will not be scrolled anymore, it will use the longest text as its > > width, then the timeline will use up what the remains. > > Do some more testing locally, because at the moment, it definitely doesn't > do that at the moment. I found I haven't deployed it, will try again. Created attachment 374815 [details]
Patch
(In reply to Zhifei Fang from comment #6) > Created attachment 374815 [details] > Patch Deployed, I found I also need to delete those customized styles. Before we land, I'd like to run the change by bot watchers to make sure they like the difference. The fixed width of the names feels solid to me and is definitely more readable. (In reply to Truitt Savell from comment #9) > The fixed width of the names feels solid to me and is definitely more > readable. Ok! r+ed then! Comment on attachment 374815 [details] Patch Clearing flags on attachment: 374815 Committed r247830: <https://trac.webkit.org/changeset/247830> All reviewed patches have been landed. Closing bug. |