Bug 200034

Summary: StringBuilder::append(makeString(...)) is inefficient
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit Misc.Assignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2019-07-23 09:30:56 PDT
Now that we have StringBuilder::flexibleAppend(), we should replace the inefficient use of StringBuilder::append(makeString(...)) to avoid the unneeded string allocation.
Attachments
WIP (82.37 KB, patch)
2019-07-23 09:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (88.56 KB, patch)
2019-07-28 11:14 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (89.47 KB, patch)
2019-07-28 12:36 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (89.46 KB, patch)
2019-07-29 12:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2019-07-23 09:34:24 PDT
Created attachment 374684 [details] WIP
Sam Weinig
Comment 2 2019-07-28 11:14:03 PDT
Created attachment 375042 [details] Patch
Sam Weinig
Comment 3 2019-07-28 12:36:54 PDT
Created attachment 375044 [details] Patch
Saam Barati
Comment 4 2019-07-28 17:28:52 PDT
Comment on attachment 375044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375044&action=review Nice > Source/WebCore/ChangeLog:14 > + A lot more can be done to improve the efficiency of StringBuilder use in the WHLSL code including: Good tips. I might look into doing some of these. Metal codegen is one of the most expensive phases in WHLSL codegen.
Sam Weinig
Comment 5 2019-07-29 12:34:27 PDT
Created attachment 375091 [details] Patch
WebKit Commit Bot
Comment 6 2019-07-29 13:12:32 PDT
Comment on attachment 375091 [details] Patch Clearing flags on attachment: 375091 Committed r247917: <https://trac.webkit.org/changeset/247917>
WebKit Commit Bot
Comment 7 2019-07-29 13:12:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-07-29 13:13:17 PDT
<rdar://problem/53675482>
Note You need to log in before you can comment on or make changes to this bug.