Summary: | slides.google.com: opening speaker notes while presenting causes a fatal error in the web app on iPad | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||||||
Component: | HTML Editing | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, bfulgham, cdumez, commit-queue, darin, dbates, ews-watchlist, japhet, jer.noble, rniwa, webkit-bug-importer, wenson_hsieh, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Maciej Stachowiak
2019-07-18 23:08:42 PDT
We could allow about:invalid#zClosureZ to be considered as same origin as the opener (like about:blank). Or we could simply consider that opening about:invalid#zClosureZ is opening about:blank. Created attachment 374975 [details]
Patch
Created attachment 374976 [details]
Patch
Created attachment 374977 [details]
Patch
Comment on attachment 374977 [details]
Patch
Maybe too risky for the short term, but should we instead just always unconditionally treat all "about:" URLs as "about:blank"?
(In reply to Darin Adler from comment #6) > Comment on attachment 374977 [details] > Patch > > Maybe too risky for the short term, but should we instead just always > unconditionally treat all "about:" URLs as "about:blank"? Yes, I reduced the exposure for now. I looked a bit at what Chrome, Firefox and Safari are doing, and the interop there is very low. Chrome and Firefox do, in some cases, process partially about:XX as about:blank. This might be worth documenting the behaviours and try converging. Comment on attachment 374977 [details] Patch Clearing flags on attachment: 374977 Committed r247873: <https://trac.webkit.org/changeset/247873> All reviewed patches have been landed. Closing bug. |