Bug 199867

Summary: [ews-build] Enable iOS WK2 tester queue on new EWS
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199944
Attachments:
Description Flags
Patch
none
Patch jbedard: review+

Aakash Jain
Reported 2019-07-17 09:55:51 PDT
Enable iOS WK2 (tester) queue on new EWS.
Attachments
Patch (3.36 KB, patch)
2019-07-17 09:59 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (5.22 KB, patch)
2019-07-18 13:57 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-07-17 09:59:51 PDT
Created attachment 374301 [details] Patch
Jonathan Bedard
Comment 2 2019-07-18 13:39:56 PDT
Comment on attachment 374301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374301&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:42 > + ALL_QUEUES = ['ios', 'ios-sim', 'gtk', 'wpe', 'wincairo', 'ios-wk2', 'api-ios', 'api-mac', 'bindings', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2', Why do we have ios-sim and ios-wk2? Is ios-sim API tests?
Aakash Jain
Comment 3 2019-07-18 13:48:12 PDT
> Why do we have ios-sim and ios-wk2? Is ios-sim API tests? 'ios-sim' is the builder queue, and 'ios-wk2' is the tester queue. https://ews-build.webkit.org/#/builders/13 https://ews-build.webkit.org/#/builders/18 API test is different, 'api-ios'. We have been running ios-sim builder queue on new EWS for a while, so that it can trigger ios-api. However, we didn't display the 'ios-sim' bubble as old EWS was displaying that bubble (which was for build + test). Now that we will be removing old EWS' 'ios-sim' bubble, we should display both builder and tester bubbles on new EWS. With this patch, for iOS we will start getting the benefit of building once and testing on multiple queues (WK2, API).
Aakash Jain
Comment 4 2019-07-18 13:57:55 PDT
Created attachment 374414 [details] Patch
Aakash Jain
Comment 5 2019-07-18 13:58:35 PDT
(In reply to Aakash Jain from comment #4) > Created attachment 374414 [details] > Patch Also removing the queue from old EWS in this patch itself.
Aakash Jain
Comment 6 2019-07-18 15:35:51 PDT
Committed r247622: <https://trac.webkit.org/changeset/247622>
Radar WebKit Bug Importer
Comment 7 2019-07-18 15:36:19 PDT
<rdar://problem/53276794>
Note You need to log in before you can comment on or make changes to this bug.