Bug 199865

Summary: Hop to the main thread when doing logging in RealtimeIncomingVideoSourceCocoa
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2019-07-17 09:03:10 PDT
Hop to the main thread when doing logging in RealtimeIncomingVideoSourceCocoa
Attachments
Patch (3.77 KB, patch)
2019-07-17 09:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-07-17 09:06:43 PDT
Created attachment 374298 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-07-17 09:06:55 PDT
<rdar://problem/53205430>
Darin Adler
Comment 3 2019-07-17 09:23:33 PDT
Comment on attachment 374298 [details] Patch This looks like a fine way to fix this case. Any ideas on how to notice in the future when we accidentally log on non-main threads?
Darin Adler
Comment 4 2019-07-17 09:23:55 PDT
Also, is there an easy way to make Logger itself handle this so we don’t push the responsibility onto all the callers?
youenn fablet
Comment 5 2019-07-17 11:11:21 PDT
Yes, I think some refactoring in LoggerHelper is probably needed to make it stronger/easier to use.
WebKit Commit Bot
Comment 6 2019-07-17 11:32:30 PDT
Comment on attachment 374298 [details] Patch Clearing flags on attachment: 374298 Committed r247525: <https://trac.webkit.org/changeset/247525>
WebKit Commit Bot
Comment 7 2019-07-17 11:32:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.