Bug 199865

Summary: Hop to the main thread when doing logging in RealtimeIncomingVideoSourceCocoa
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2019-07-17 09:03:10 PDT 
Hop to the main thread when doing logging in RealtimeIncomingVideoSourceCocoa
Comment 1 youenn fablet 2019-07-17 09:06:43 PDT 
Created attachment 374298 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-07-17 09:06:55 PDT 
<rdar://problem/53205430>
Comment 3 Darin Adler 2019-07-17 09:23:33 PDT 
Comment on attachment 374298 [details]
Patch

This looks like a fine way to fix this case. Any ideas on how to notice in the future when we accidentally log on non-main threads?
Comment 4 Darin Adler 2019-07-17 09:23:55 PDT 
Also, is there an easy way to make Logger itself handle this so we don’t push the responsibility onto all the callers?
Comment 5 youenn fablet 2019-07-17 11:11:21 PDT 
Yes, I think some refactoring in LoggerHelper is probably needed to make it stronger/easier to use.
Comment 6 WebKit Commit Bot 2019-07-17 11:32:30 PDT 
Comment on attachment 374298 [details]
Patch

Clearing flags on attachment: 374298

Committed r247525: <https://trac.webkit.org/changeset/247525>
Comment 7 WebKit Commit Bot 2019-07-17 11:32:31 PDT 
All reviewed patches have been landed.  Closing bug.