Bug 199861 – Web Inspector: application/xml content not shown

• Component: Web Inspector
• Status: RESOLVED FIXED

[Olivier Blin]

application/xml content from XHR requests is not shown in the inspector.
In the network request preview tab, this error message is displayed instead: "An error occurred trying to load the resource."

application/xml content should be treated as text, since application/xml is the standard mimetype for XML content.
Apache serves XML content with the application/xml mimetype by default.

[Olivier Blin]

Created attachment 374294 [details]
Patch

[Devin Rousso]

Comment on attachment 374294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374294&action=review

r=me, nice catch!  If need someone else to cq+ (or r+ again), just let me know.

> Source/WebInspectorUI/UserInterface/Base/MIMETypeUtilities.js:290
> +        "application/xml": "xml",

We already have a mapping above for "text/xml" (>173), so please move just this line to be after that.

> Source/WebInspectorUI/UserInterface/Base/MIMETypeUtilities.js:325
> +    if (extension === "js" || extension === "json" || extension === "xml")

This shouldn't be added to this `if`, as it doesn't apply to the comment.  If anything, I'd restructure a bit of this function:
```js
    let extension = WI.fileExtensionForMIMEType(mimeType);
    if (extension === "xml")
        return true;

    // Various script/JSON mime types.
    if (extension === "js" || extension === "json")
        return true;

    // Various media text mime types.
    if (extension === "m3u8" || extension === "m3u")
        return true;
```

[Olivier Blin]

Created attachment 374316 [details]
Patch

[Olivier Blin]

Comment on attachment 374294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374294&action=review

>> Source/WebInspectorUI/UserInterface/Base/MIMETypeUtilities.js:290
>> +        "application/xml": "xml",
> 
> We already have a mapping above for "text/xml" (>173), so please move just this line to be after that.

Ok, even if content with application/xml mimetype does not really belong to the "Document" group.

>> Source/WebInspectorUI/UserInterface/Base/MIMETypeUtilities.js:325
>> +    if (extension === "js" || extension === "json" || extension === "xml")
> 
> This shouldn't be added to this `if`, as it doesn't apply to the comment.  If anything, I'd restructure a bit of this function:
> ```js
>     let extension = WI.fileExtensionForMIMEType(mimeType);
>     if (extension === "xml")
>         return true;
> 
>     // Various script/JSON mime types.
>     if (extension === "js" || extension === "json")
>         return true;
> 
>     // Various media text mime types.
>     if (extension === "m3u8" || extension === "m3u")
>         return true;
> ```

Done

Thanks for the review!

[Devin Rousso]

Comment on attachment 374316 [details]
Patch

r=me, thanks :)

[WebKit Commit Bot]

Comment on attachment 374316 [details]
Patch

Clearing flags on attachment: 374316

Committed r247533: <https://trac.webkit.org/changeset/247533>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53218724>