Bug 199849

Summary: Fix includes and make a constructor explicit to avoid unified-sources-triggered test failures
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, dbates, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199587
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2019-07-16 20:54:17 PDT 
Fix includes and make a constructor explicit to avoid unified-sources-triggered test failures
Comment 1 Simon Fraser (smfr) 2019-07-16 20:56:09 PDT 
Created attachment 374274 [details]
Patch
Comment 2 Daniel Bates 2019-07-16 21:09:19 PDT 
Wow this bug (NOT YOUR PATCH) really makes me 😡. It makes me 😡 because of the fear of the unknown. How many yet undiscovered correctness issues are unified source causing? When you spend so much time fixing bugs only for weird bugs to be introduced by the build system that's next level bull....
Comment 3 WebKit Commit Bot 2019-07-16 21:56:42 PDT 
Comment on attachment 374274 [details]
Patch

Clearing flags on attachment: 374274

Committed r247504: <https://trac.webkit.org/changeset/247504>
Comment 4 WebKit Commit Bot 2019-07-16 21:56:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-07-16 21:57:22 PDT 
<rdar://problem/53187799>