Summary: | [WHLSL] Move WHLSL tests to their own folder | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, rmorisset, tsavell, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2019-07-16 14:33:36 PDT
Created attachment 374241 [details]
Patch
Comment on attachment 374241 [details]
Patch
rs=me
Comment on attachment 374241 [details] Patch Rejecting attachment 374241 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 374241, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: whlsl/overload.html patching file LayoutTests/webgpu/whlsl/override-subscript-expected.txt patching file LayoutTests/webgpu/whlsl/override-subscript.html patching file LayoutTests/webgpu/whlsl/plus-equals-expected.txt patching file LayoutTests/webgpu/whlsl/plus-equals.html patching file LayoutTests/webgpu/whlsl/pointer-spec-tests-expected.txt patching file LayoutTests/webgpu/whlsl/pointer-spec-tests.html patching file LayoutTests/webgpu/whlsl/postfix-prefix-expected.txt patching file LayoutTests/webgpu/whlsl/postfix-prefix.html patching file LayoutTests/webgpu/whlsl/read-modify-write-expected.txt patching file LayoutTests/webgpu/whlsl/read-modify-write-high-zombies-expected.txt patching file LayoutTests/webgpu/whlsl/read-modify-write-high-zombies.html patching file LayoutTests/webgpu/whlsl/read-modify-write.html patching file LayoutTests/webgpu/whlsl/recursive-structs-expected.txt patching file LayoutTests/webgpu/whlsl/recursive-structs.html patching file LayoutTests/webgpu/whlsl/return-local-variable-expected.html patching file LayoutTests/webgpu/whlsl/return-local-variable.html patching file LayoutTests/webgpu/whlsl/return-spec-tests-expected.txt patching file LayoutTests/webgpu/whlsl/return-spec-tests.html patching file LayoutTests/webgpu/whlsl/setter-spec-tests-expected.txt patching file LayoutTests/webgpu/whlsl/setter-spec-tests.html patching file LayoutTests/webgpu/whlsl/simple-arrays-expected.txt patching file LayoutTests/webgpu/whlsl/simple-arrays.html patching file LayoutTests/webgpu/whlsl/simple-getter-setter-expected.txt patching file LayoutTests/webgpu/whlsl/simple-getter-setter.html patching file LayoutTests/webgpu/whlsl/simple-tests-expected.txt patching file LayoutTests/webgpu/whlsl/simple-tests.html patching file LayoutTests/webgpu/whlsl/simple-while-loop-expected.txt patching file LayoutTests/webgpu/whlsl/simple-while-loop.html patching file LayoutTests/webgpu/whlsl/store-null-expected.txt patching file LayoutTests/webgpu/whlsl/store-null.html patching file LayoutTests/webgpu/whlsl/store-to-property-updates-properly-expected.html patching file LayoutTests/webgpu/whlsl/store-to-property-updates-properly.html patching file LayoutTests/webgpu/whlsl/struct-expected.txt patching file LayoutTests/webgpu/whlsl/struct.html patching file LayoutTests/webgpu/whlsl/switch-expected.txt patching file LayoutTests/webgpu/whlsl/switch.html patching file LayoutTests/webgpu/whlsl/ternary-spec-test-expected.txt patching file LayoutTests/webgpu/whlsl/ternary-spec-test.html patching file LayoutTests/webgpu/whlsl/test-harness-test-expected.txt patching file LayoutTests/webgpu/whlsl/test-harness-test.html patching file LayoutTests/webgpu/whlsl/textures-getdimensions-expected.txt patching file LayoutTests/webgpu/whlsl/textures-getdimensions.html patching file LayoutTests/webgpu/whlsl/textures-load-expected.html patching file LayoutTests/webgpu/whlsl/textures-load.html patching file LayoutTests/webgpu/whlsl/textures-sample-expected.html patching file LayoutTests/webgpu/whlsl/textures-sample.html patching file LayoutTests/webgpu/whlsl/two-dimensional-array-expected.txt patching file LayoutTests/webgpu/whlsl/two-dimensional-array.html patching file LayoutTests/webgpu/whlsl/type-mismatch-expected.txt patching file LayoutTests/webgpu/whlsl/type-mismatch.html patching file LayoutTests/webgpu/whlsl/uint-bitwise-expected.txt patching file LayoutTests/webgpu/whlsl/uint-bitwise.html patching file LayoutTests/webgpu/whlsl/use-undefined-variable-2-expected.txt patching file LayoutTests/webgpu/whlsl/use-undefined-variable-2.html patching file LayoutTests/webgpu/whlsl/use-undefined-variable-expected.txt patching file LayoutTests/webgpu/whlsl/use-undefined-variable.html patching file LayoutTests/webgpu/whlsl/variable-shadowing-expected.txt patching file LayoutTests/webgpu/whlsl/variable-shadowing.html patching file LayoutTests/webgpu/whlsl/vector-syntax-expected.txt patching file LayoutTests/webgpu/whlsl/vector-syntax.html patching file LayoutTests/webgpu/whlsl/while-loop-break-expected.html patching file LayoutTests/webgpu/whlsl/while-loop-break.html patching file LayoutTests/webgpu/whlsl/while-loop-continue-expected.html patching file LayoutTests/webgpu/whlsl/while-loop-continue.html patching file LayoutTests/webgpu/whlsl/whlsl.html patching file LayoutTests/webgpu/whlsl/wrong-argument-length-expected.txt patching file LayoutTests/webgpu/whlsl/wrong-argument-length.html patching file LayoutTests/webgpu/whlsl/wrong-types-expected.txt patching file LayoutTests/webgpu/whlsl/wrong-types.html patching file LayoutTests/webgpu/whlsl/zero-initialize-values-2-expected.html patching file LayoutTests/webgpu/whlsl/zero-initialize-values-2.html patching file LayoutTests/webgpu/whlsl/zero-initialize-values-expected.html patching file LayoutTests/webgpu/whlsl/zero-initialize-values.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Robin Morisset']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12753492 Created attachment 374243 [details]
Patch for committing
Created attachment 374244 [details]
Patch for committing
Comment on attachment 374244 [details] Patch for committing Rejecting attachment 374244 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 374244, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: sl/postfix-prefix.html patching file LayoutTests/webgpu/whlsl/read-modify-write-expected.txt patching file LayoutTests/webgpu/whlsl/read-modify-write-high-zombies-expected.txt patching file LayoutTests/webgpu/whlsl/read-modify-write-high-zombies.html patching file LayoutTests/webgpu/whlsl/read-modify-write.html patching file LayoutTests/webgpu/whlsl/recursive-structs-expected.txt patching file LayoutTests/webgpu/whlsl/recursive-structs.html patching file LayoutTests/webgpu/whlsl/return-local-variable-expected.html patching file LayoutTests/webgpu/whlsl/return-local-variable.html patching file LayoutTests/webgpu/whlsl/return-spec-tests-expected.txt patching file LayoutTests/webgpu/whlsl/return-spec-tests.html patching file LayoutTests/webgpu/whlsl/setter-spec-tests-expected.txt patching file LayoutTests/webgpu/whlsl/setter-spec-tests.html patching file LayoutTests/webgpu/whlsl/simple-arrays-expected.txt patching file LayoutTests/webgpu/whlsl/simple-arrays.html patching file LayoutTests/webgpu/whlsl/simple-getter-setter-expected.txt patching file LayoutTests/webgpu/whlsl/simple-getter-setter.html patching file LayoutTests/webgpu/whlsl/simple-tests-expected.txt patching file LayoutTests/webgpu/whlsl/simple-tests.html patching file LayoutTests/webgpu/whlsl/simple-while-loop-expected.txt patching file LayoutTests/webgpu/whlsl/simple-while-loop.html patching file LayoutTests/webgpu/whlsl/store-null-expected.txt patching file LayoutTests/webgpu/whlsl/store-null.html patching file LayoutTests/webgpu/whlsl/store-to-property-updates-properly-expected.html patching file LayoutTests/webgpu/whlsl/store-to-property-updates-properly.html patching file LayoutTests/webgpu/whlsl/struct-expected.txt patching file LayoutTests/webgpu/whlsl/struct.html patching file LayoutTests/webgpu/whlsl/switch-expected.txt patching file LayoutTests/webgpu/whlsl/switch.html patching file LayoutTests/webgpu/whlsl/ternary-spec-test-expected.txt patching file LayoutTests/webgpu/whlsl/ternary-spec-test.html patching file LayoutTests/webgpu/whlsl/test-harness-test-expected.txt patching file LayoutTests/webgpu/whlsl/test-harness-test.html patching file LayoutTests/webgpu/whlsl/textures-getdimensions-expected.txt patching file LayoutTests/webgpu/whlsl/textures-getdimensions.html patching file LayoutTests/webgpu/whlsl/textures-load-expected.html patching file LayoutTests/webgpu/whlsl/textures-load.html patching file LayoutTests/webgpu/whlsl/textures-sample-expected.html patching file LayoutTests/webgpu/whlsl/textures-sample.html patching file LayoutTests/webgpu/whlsl/two-dimensional-array-expected.txt patching file LayoutTests/webgpu/whlsl/two-dimensional-array.html patching file LayoutTests/webgpu/whlsl/type-mismatch-expected.txt patching file LayoutTests/webgpu/whlsl/type-mismatch.html patching file LayoutTests/webgpu/whlsl/uint-bitwise-expected.txt patching file LayoutTests/webgpu/whlsl/uint-bitwise.html patching file LayoutTests/webgpu/whlsl/use-undefined-variable-2-expected.txt patching file LayoutTests/webgpu/whlsl/use-undefined-variable-2.html patching file LayoutTests/webgpu/whlsl/use-undefined-variable-expected.txt patching file LayoutTests/webgpu/whlsl/use-undefined-variable.html patching file LayoutTests/webgpu/whlsl/variable-shadowing-expected.txt patching file LayoutTests/webgpu/whlsl/variable-shadowing.html patching file LayoutTests/webgpu/whlsl/vector-syntax-expected.txt patching file LayoutTests/webgpu/whlsl/vector-syntax.html patching file LayoutTests/webgpu/whlsl/while-loop-break-expected.html patching file LayoutTests/webgpu/whlsl/while-loop-break.html patching file LayoutTests/webgpu/whlsl/while-loop-continue-expected.html patching file LayoutTests/webgpu/whlsl/while-loop-continue.html patching file LayoutTests/webgpu/whlsl/whlsl.html patching file LayoutTests/webgpu/whlsl/wrong-argument-length-expected.txt patching file LayoutTests/webgpu/whlsl/wrong-argument-length.html patching file LayoutTests/webgpu/whlsl/wrong-types-expected.txt patching file LayoutTests/webgpu/whlsl/wrong-types.html patching file LayoutTests/webgpu/whlsl/zero-initialize-values-2-expected.html patching file LayoutTests/webgpu/whlsl/zero-initialize-values-2.html patching file LayoutTests/webgpu/whlsl/zero-initialize-values-expected.html patching file LayoutTests/webgpu/whlsl/zero-initialize-values.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 7c1264d7b1c..35516a5d942 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 247498 = 7c1264d7b1c4efce081b8266f3dded08ae16fcab r247499 = 35516a5d94222ffb584fde90670650657962790c Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/12754297 Committed r247501: <https://trac.webkit.org/changeset/247501> Reverted r247501 for reason: Introduced 100 failures on Mojave WK2. Committed r247513: <https://trac.webkit.org/changeset/247513> This change seems to have introduced 100 failures on Mojave WK2 Build: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/5360 This only effected Mojave WK2 which is not tested on EWS, and was not caught by EWS because webgpu is disabled on High Sierra. It looks like this change requires updating expectations for all these tests to include the new file paths possibly. Committed r247528: <https://trac.webkit.org/changeset/247528> |