Bug 199825

Summary: Fix build warning because of missing super_class initializer
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: WebKit Misc.Assignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbedard, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Frédéric Wang (:fredw) 2019-07-16 03:43:29 PDT 
This happens in WebKit/UIProcess/ios/WKContentView.mm when building iOS 13 with XCode beta and public SDK.
Comment 1 Frédéric Wang (:fredw) 2019-07-16 03:48:20 PDT 
Created attachment 374203 [details]
Patch
Comment 2 Jonathan Bedard 2019-07-16 11:09:57 PDT 
Comment on attachment 374203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374203&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:152
> +    struct objc_super super { self, class_getSuperclass(object_getClass(self)) };

Looking through other code which set's struct values, seems that we prefer:

struct objc_super super = { self, class_getSuperclass(object_getClass(self)) };
Comment 3 Frédéric Wang (:fredw) 2019-07-16 12:07:50 PDT 
Created attachment 374229 [details]
Patch
Comment 4 WebKit Commit Bot 2019-07-16 13:08:32 PDT 
Comment on attachment 374229 [details]
Patch

Clearing flags on attachment: 374229

Committed r247491: <https://trac.webkit.org/changeset/247491>
Comment 5 WebKit Commit Bot 2019-07-16 13:08:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-16 13:09:15 PDT 
<rdar://problem/53167674>