Bug 199819

Summary:

[iOS WK2] Avoid lots of compositing backing store for offscreen position:fixed descendants

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Compositing

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews115 for mac-highsierra	none
Archive of layout-test-results from ews102 for mac-highsierra	none
Archive of layout-test-results from ews107 for mac-highsierra-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none

Simon Fraser (smfr)

Reported 2019-07-15 19:00:18 PDT

[iOS WK2] Avoid lots of compositing backing store for offscreen position:fixed descendants

Attachments
Patch (32.57 KB, patch) 2019-07-15 19:00 PDT, Simon Fraser (smfr)	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-highsierra (398.22 KB, application/zip) 2019-07-15 20:09 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews102 for mac-highsierra (3.21 MB, application/zip) 2019-07-15 20:14 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.82 MB, application/zip) 2019-07-15 20:23 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.77 MB, application/zip) 2019-07-15 21:40 PDT, EWS Watchlist	no flags	Details
Patch (38.96 KB, patch) 2019-07-15 23:00 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.64 MB, application/zip) 2019-07-16 01:03 PDT, EWS Watchlist	no flags	Details
Patch (41.66 KB, text/plain) 2019-07-16 08:55 PDT, Simon Fraser (smfr)	ews-watchlist: commit-queue-	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.68 MB, application/zip) 2019-07-16 11:00 PDT, EWS Watchlist	no flags	Details
Patch (49.83 KB, patch) 2019-07-17 09:44 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2019-07-15 19:00:32 PDT

Created attachment 374178 [details] Patch

EWS Watchlist

Comment 2 2019-07-15 19:02:17 PDT Comment hidden (obsolete)

Attachment 374178 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2019-07-15 20:09:00 PDT Comment hidden (obsolete)

Comment on attachment 374178 [details] Patch Attachment 374178 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12747283 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2019-07-15 20:09:02 PDT Comment hidden (obsolete)

Created attachment 374186 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-07-15 20:14:33 PDT Comment hidden (obsolete)

Comment on attachment 374178 [details] Patch Attachment 374178 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12747399 New failing tests: compositing/layer-creation/fixed-position-change-out-of-view-in-view.html fast/repaint/absolute-position-change-containing-block.html compositing/layer-creation/fixed-position-out-of-view.html compositing/layer-creation/fixed-position-transformed-outside-view.html

EWS Watchlist

Comment 6 2019-07-15 20:14:35 PDT Comment hidden (obsolete)

Created attachment 374188 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-07-15 20:23:42 PDT Comment hidden (obsolete)

Comment on attachment 374178 [details] Patch Attachment 374178 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12747418 New failing tests: tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex.html compositing/layer-creation/fixed-position-change-out-of-view-in-view.html compositing/layer-creation/fixed-position-out-of-view.html compositing/layer-creation/fixed-position-transformed-outside-view.html tiled-drawing/scrolling/fixed/fixed-position-out-of-view.html fast/repaint/absolute-position-change-containing-block.html

EWS Watchlist

Comment 8 2019-07-15 20:23:44 PDT Comment hidden (obsolete)

Created attachment 374189 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2019-07-15 21:40:00 PDT Comment hidden (obsolete)

Comment on attachment 374178 [details] Patch Attachment 374178 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12747705 New failing tests: compositing/layer-creation/fixed-position-change-out-of-view-in-view.html fast/scrolling/ios/reconcile-layer-position-recursive.html compositing/layer-creation/fixed-position-transformed-outside-view.html

EWS Watchlist

Comment 10 2019-07-15 21:40:01 PDT Comment hidden (obsolete)

Created attachment 374192 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Simon Fraser (smfr)

Comment 11 2019-07-15 23:00:36 PDT Comment hidden (obsolete)

Created attachment 374194 [details] Patch

EWS Watchlist

Comment 12 2019-07-16 01:03:02 PDT Comment hidden (obsolete)

Comment on attachment 374194 [details] Patch Attachment 374194 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12748642 New failing tests: fast/scrolling/ios/reconcile-layer-position-recursive.html

EWS Watchlist

Comment 13 2019-07-16 01:03:05 PDT Comment hidden (obsolete)

Created attachment 374200 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Simon Fraser (smfr)

Comment 14 2019-07-16 08:55:33 PDT Comment hidden (obsolete)

Created attachment 374211 [details] Patch

EWS Watchlist

Comment 15 2019-07-16 11:00:14 PDT Comment hidden (obsolete)

Comment on attachment 374211 [details] Patch Attachment 374211 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12751216 New failing tests: fast/scrolling/ios/reconcile-layer-position-recursive.html

EWS Watchlist

Comment 16 2019-07-16 11:00:15 PDT Comment hidden (obsolete)

Created attachment 374219 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Simon Fraser (smfr)

Comment 17 2019-07-17 09:44:52 PDT

Created attachment 374300 [details] Patch

WebKit Commit Bot

Comment 18 2019-07-17 15:49:47 PDT

Comment on attachment 374300 [details] Patch Clearing flags on attachment: 374300 Committed r247540: <https://trac.webkit.org/changeset/247540>

WebKit Commit Bot

Comment 19 2019-07-17 15:49:49 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 20 2019-07-17 15:50:27 PDT

<rdar://problem/53225521>

Note You need to log in before you can comment on or make changes to this bug.