Summary: | [iOS] REGRESSION (r241734): Autocorrection highlight should hide when field becomes defocused | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | megan_gardner, webkit-bug-importer, wenson_hsieh | ||||||||||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly, Regression | ||||||||||||
Version: | WebKit Local Build | ||||||||||||||
Hardware: | iPhone / iPad | ||||||||||||||
OS: | Unspecified | ||||||||||||||
URL: | data:text/html,<input><button>Tap</button> | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=197746 | ||||||||||||||
Bug Depends on: | 192824 | ||||||||||||||
Bug Blocks: | 190571 | ||||||||||||||
Attachments: |
|
Description
Daniel Bates
2019-07-15 14:17:14 PDT
Created attachment 374148 [details]
For the bots
Patch no good. Already nilled the inputDelegate Created attachment 374160 [details]
For the Bots
Created attachment 374348 [details]
Alternative for the bots
Created attachment 374349 [details]
Alt for the bots
Created attachment 374421 [details]
Patch
It is not possible to write a reproducible test case for this change at the moment because the Input Manager learns to ignore misspelling when a correction is repeatedly ignored/rejected (say, as a result of running a test more than once) and these learnings persist across Simulator reboots. There is no way to tell the Input Manager to unlearn a misspelling as far as I can tell.
Comment on attachment 374421 [details] Patch Clearing flags on attachment: 374421 Committed r247653: <https://trac.webkit.org/changeset/247653> All reviewed patches have been landed. Closing bug. (In reply to Daniel Bates from comment #8) > Comment on attachment 374421 [details] > Patch > > Clearing flags on attachment: 374421 > > Committed r247653: <https://trac.webkit.org/changeset/247653> Wow! This is a bad merge. Svn-apply couldn't find -_didCommitLoadForMainFrame and patch -clearSelection instead Fixed bad merge in <https://trac.webkit.org/changeset/247687> |