Bug 199802

Summary: Add missing webgpu includes
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebCore Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-07-15 13:31:27 PDT
WHLSLFunctionWriter.cpp fails to compile on tvOS and watchOS due to missing includes. This file likely compiles on other platforms due to the Unified Sources facility that clumps several implementation files together, exposing those implementation files to the others' includes. It fails on tvOS and watchOS due to the different ways these implementation files can get clumped together on different platforms.
Attachments
Patch (1.78 KB, patch)
2019-07-15 13:34 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-07-15 13:32:15 PDT
<rdar://problem/53119120>
Keith Rollin
Comment 2 2019-07-15 13:34:27 PDT
Created attachment 374142 [details] Patch
WebKit Commit Bot
Comment 3 2019-07-15 14:40:34 PDT
Comment on attachment 374142 [details] Patch Clearing flags on attachment: 374142 Committed r247450: <https://trac.webkit.org/changeset/247450>
WebKit Commit Bot
Comment 4 2019-07-15 14:40:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.