Bug 199773 – [WebGPU] Convert GPUComputePipeline LOG statements to generate GPUErrors

• Component: WebGPU
• Status: RESOLVED FIXED

[Justin Fan]

[WebGPU] Convert GPUComputePipeline LOG statements to generate GPUErrors

[Justin Fan]

Created attachment 374067 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 374067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374067&action=review

> LayoutTests/webgpu/compute-pipeline-errors.html:45
> +    const badMSL = `We should hydrate. With some beers.`;

👎 please no

Also beers usually have enough salt that they don’t hydrate you

[Justin Fan]

Created attachment 374134 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 374134 [details]
Patch for landing

Rejecting attachment 374134 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 374134, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=374134&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199773&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 374134 from bug 199773.
Fetching: https://bugs.webkit.org/attachment.cgi?id=374134
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 20 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/webgpu/WebGPUComputePipelineDescriptor.cpp
patching file Source/WebCore/Modules/webgpu/WebGPUComputePipelineDescriptor.h
patching file Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
Hunk #1 succeeded at 158 (offset -6 lines).
patching file Source/WebCore/platform/graphics/gpu/GPUBuffer.h
Hunk #1 FAILED at 111.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/gpu/GPUBuffer.h.rej
patching file Source/WebCore/platform/graphics/gpu/GPUComputePipeline.h
patching file Source/WebCore/platform/graphics/gpu/GPUDevice.cpp
Hunk #1 succeeded at 85 (offset -2 lines).
patching file Source/WebCore/platform/graphics/gpu/GPUDevice.h
Hunk #1 succeeded at 74 (offset -5 lines).
patching file Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm
Hunk #1 FAILED at 42.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm.rej
patching file Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/webgpu/compute-pipeline-errors-expected.txt
patching file LayoutTests/webgpu/compute-pipeline-errors.html
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: LayoutTests/webgpu/error-scopes-test.html
|index 5cfcca1b5e141ad4759bf2daea2ed25944647515..856afa8edc1a1e72402c6666e4e38f8f3358fa64 100644
|--- LayoutTests/webgpu/error-scopes-test.html	(revision 0)
|+++ LayoutTests/webgpu/error-scopes-test.html	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patching file LayoutTests/webgpu/js/webgpu-functions.js
patching file LayoutTests/webgpu/js/whlsl-test-harness.js
patching file LayoutTests/webgpu/whlsl-recursive-structs-expected.txt
patching file LayoutTests/webgpu/whlsl-recursive-structs.html
patching file LayoutTests/webgpu/whlsl-test-harness-test-expected.txt
patching file LayoutTests/webgpu/whlsl-test-harness-test.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12744996

[Justin Fan]

Earlier error checking patches got rolled out, so reapplying this after fixing those.

[Justin Fan]

Created attachment 374245 [details]
Patch

[Justin Fan]

Created attachment 374257 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374257 [details]
Patch

Clearing flags on attachment: 374257

Committed r247500: <https://trac.webkit.org/changeset/247500>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53179280>