Bug 199772

Summary: Add accessibility support to WKDataListSuggestionsView.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2019-07-12 18:49:06 PDT
Add accessibility support to WKDataListSuggestionsView.
Comment 1 Andres Gonzalez 2019-07-12 18:58:46 PDT
Created attachment 374066 [details]
Patch
Comment 2 chris fleizach 2019-07-12 19:06:25 PDT
Comment on attachment 374066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374066&action=review

> Source/WebCore/en.lproj/Localizable.strings:784
>  /* Undo action name */

Can your comment explain what will go in the format argument so localizers know what will be in there?
Comment 3 Andres Gonzalez 2019-07-12 20:07:51 PDT
Created attachment 374075 [details]
Patch
Comment 4 Andres Gonzalez 2019-07-12 20:18:13 PDT
(In reply to chris fleizach from comment #2)
> Comment on attachment 374066 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374066&action=review
> 
> > Source/WebCore/en.lproj/Localizable.strings:784
> >  /* Undo action name */
> 
> Can your comment explain what will go in the format argument so localizers
> know what will be in there?

Done.
Comment 5 WebKit Commit Bot 2019-07-13 10:28:47 PDT
Comment on attachment 374075 [details]
Patch

Clearing flags on attachment: 374075

Committed r247418: <https://trac.webkit.org/changeset/247418>
Comment 6 WebKit Commit Bot 2019-07-13 10:28:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-13 10:29:19 PDT
<rdar://problem/53054799>