Bug 199772

Summary: Add accessibility support to WKDataListSuggestionsView.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2019-07-12 18:49:06 PDT
Add accessibility support to WKDataListSuggestionsView.
Attachments
Patch (5.23 KB, patch)
2019-07-12 18:58 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (5.34 KB, patch)
2019-07-12 20:07 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2019-07-12 18:58:46 PDT
Created attachment 374066 [details] Patch
chris fleizach
Comment 2 2019-07-12 19:06:25 PDT
Comment on attachment 374066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374066&action=review > Source/WebCore/en.lproj/Localizable.strings:784 > /* Undo action name */ Can your comment explain what will go in the format argument so localizers know what will be in there?
Andres Gonzalez
Comment 3 2019-07-12 20:07:51 PDT
Created attachment 374075 [details] Patch
Andres Gonzalez
Comment 4 2019-07-12 20:18:13 PDT
(In reply to chris fleizach from comment #2) > Comment on attachment 374066 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374066&action=review > > > Source/WebCore/en.lproj/Localizable.strings:784 > > /* Undo action name */ > > Can your comment explain what will go in the format argument so localizers > know what will be in there? Done.
WebKit Commit Bot
Comment 5 2019-07-13 10:28:47 PDT
Comment on attachment 374075 [details] Patch Clearing flags on attachment: 374075 Committed r247418: <https://trac.webkit.org/changeset/247418>
WebKit Commit Bot
Comment 6 2019-07-13 10:28:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-07-13 10:29:19 PDT
<rdar://problem/53054799>
Note You need to log in before you can comment on or make changes to this bug.