Bug 19977
| Summary: | Remove handmade autogen.sh in favor of autoreconf -i | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Landry Breuil <landry> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | UNCONFIRMED | ||
| Severity: | Normal | CC: | ahmad.saleem792, alp, ddkilzer, gsnedders, jbedard |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Other | ||
Landry Breuil
There's no real need to have a handmade autogen.sh when this facility is provided by autoreconf -i : autoreconf comes with autoconf package and takes care of running aclocal/autoheader/autoconf/automake in the right order. -i is the equivalent of --add-missing for autoconf.
- also, there's no need to touch empty README/INSTALL.. just provide real ones.
- this is maybe a return of bug https://bugs.webkit.org/show_bug.cgi?id=16665, i agree with the OP, auto* system should not call configure too. It's only here to prepare things for configure.
- $top_srcdir in autogen.sh is undefined, this may lead to errors. (trying to remove something in / is bad :)
Btw, removing autogen.sh in favor of documenting and using autoreconf -i instead allows to build in a separate directory, like requested in a previous bug.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Landry Breuil
After multiple tests, autogen.sh can effectively be replaced by a call to 'autoreconf --install', followed by a call to 'automake --add-missing --copy' to cope with a bug in autoreconf not installing install-sh, missing and depcomp (cf http://www.freesoftwaremagazine.com/books/agaal/configuring_a_project_with_autoconf for details)
Documenting this procedure in an INSTALL file could be a good option :) autogen.sh scripts tend to be deprecated..
Ahmad Saleem
We have following reference of 'autogen.sh' in WebKit upstream code.
https://github.com/search?q=repo%3AWebKit%2FWebKit%20autogen.sh&type=code