[WHLSL] Return statements don't need to keep track of the function they're in

• Component: WebGPU
• Status: RESOLVED FIXED

[Robin Morisset]

This is only used in the Checker, and it can easily keep track of the current function.
Doing it this way spares us from tracking the current function in the name resolver, and saves 8 bytes from every Return.

[Robin Morisset]

Created attachment 374046 [details]
Patch

Not yet up for review because I've not yet tested it.

[Robin Morisset]

Comment on attachment 374046 [details]
Patch

It passes all tests, so asking for review.

[Myles C. Maxfield]

Comment on attachment 374046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374046&action=review

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReturn.h:-60
> -    void setFunction(FunctionDefinition* functionDefinition) { m_function = functionDefinition; }

We might have to add this back in if we add a pass to inline things.

[WebKit Commit Bot]

Comment on attachment 374046 [details]
Patch

Clearing flags on attachment: 374046

Committed r247419: <https://trac.webkit.org/changeset/247419>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53054937>