Bug 199760

Summary: Web Inspector: Changes: dismissing a blank property makes style rule to show in Changes panel
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch none

Nikita Vasilyev
Reported 2019-07-12 14:42:40 PDT
Created attachment 374036 [details] [Animated GIF] Bug Steps: 1. Inspect <body> (or any element) 2. In the Styles panel, click to add a new CSS property 3. Click elsewhere to dismiss it 4. Select Changes panel Expected: Changes panel is empty Actual: Changes panel shows one CSS rule. All text is gray; no additions or deletions.
Attachments
[Animated GIF] Bug (43.99 KB, image/gif)
2019-07-12 14:42 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.41 KB, patch)
2019-07-12 14:46 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2019-07-12 14:46:23 PDT
Created attachment 374038 [details] Patch
Devin Rousso
Comment 2 2019-07-12 14:47:59 PDT
Comment on attachment 374038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374038&action=review rs=me > Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:443 > + this._ownerStyle.updatePropertiesModifiedState(); Why not move this call inside `shiftPropertiesAfter`? That way, you could remove the `updatePropertiesModifiedState` on <480 as well.
Nikita Vasilyev
Comment 3 2019-07-12 14:55:42 PDT
Comment on attachment 374038 [details] Patch (In reply to Devin Rousso from comment #2) > Comment on attachment 374038 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374038&action=review > > rs=me > > > Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:443 > > + this._ownerStyle.updatePropertiesModifiedState(); > > Why not move this call inside `shiftPropertiesAfter`? That way, you could > remove the `updatePropertiesModifiedState` on <480 as well. While it would save one line of code, I think it's more clear when shiftPropertiesAfter only shifts properties.
WebKit Commit Bot
Comment 4 2019-07-12 16:21:38 PDT
Comment on attachment 374038 [details] Patch Clearing flags on attachment: 374038 Committed r247406: <https://trac.webkit.org/changeset/247406>
WebKit Commit Bot
Comment 5 2019-07-12 16:21:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-07-12 16:24:06 PDT
<rdar://problem/53032783>
Note You need to log in before you can comment on or make changes to this bug.