| Summary: | Web Inspector: Changes: dismissing a blank property makes style rule to show in Changes panel | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 374038 [details]
Patch
Comment on attachment 374038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374038&action=review rs=me > Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:443 > + this._ownerStyle.updatePropertiesModifiedState(); Why not move this call inside `shiftPropertiesAfter`? That way, you could remove the `updatePropertiesModifiedState` on <480 as well. Comment on attachment 374038 [details] Patch (In reply to Devin Rousso from comment #2) > Comment on attachment 374038 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374038&action=review > > rs=me > > > Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:443 > > + this._ownerStyle.updatePropertiesModifiedState(); > > Why not move this call inside `shiftPropertiesAfter`? That way, you could > remove the `updatePropertiesModifiedState` on <480 as well. While it would save one line of code, I think it's more clear when shiftPropertiesAfter only shifts properties. Comment on attachment 374038 [details] Patch Clearing flags on attachment: 374038 Committed r247406: <https://trac.webkit.org/changeset/247406> All reviewed patches have been landed. Closing bug. |
Created attachment 374036 [details] [Animated GIF] Bug Steps: 1. Inspect <body> (or any element) 2. In the Styles panel, click to add a new CSS property 3. Click elsewhere to dismiss it 4. Select Changes panel Expected: Changes panel is empty Actual: Changes panel shows one CSS rule. All text is gray; no additions or deletions.