Bug 199736 – Be more robust regarding dot-prefixed fonts

• Component: Text
• Status: RESOLVED CONFIGURATION CHANGED

[Myles C. Maxfield]

https://bugs.webkit.org/show_bug.cgi?id=199653 happened because we encountered a system font that we didn't expect. The solution for that bug in particular was to start expecting that font. However, in the future we shouldn't completely fall over in that case. We should try to be more robust.

I think what this will actually entail, as far as code, is for all fonts that SystemFontDatabaseCoreText creates (and eventually end up in a FontFamilySpecificationCoreText) to be marked somehow as "This is a variable font where the instance has already been chosen". Then, in preparePlatformFont(), when we apply the weight/width/slope variations, we can skip that section on the marked fonts. Right now we do that check by asking "fontIsSystemFont(originalFont)" but instead we can use that mark. This still wouldn't be perfect, but it would probably as close as we could get without adding explicit support for each dot-prefixed font.

[Myles C. Maxfield]

Actually, this is probably a trivial patch.

[Myles C. Maxfield]

‘eyyyyy there’s already a flag that does exactly that! It looks like we should just set the flag and change the guard and be done!

[Myles C. Maxfield]

Created attachment 373980 [details]
Patch

[EWS Watchlist]

Comment on attachment 373980 [details]
Patch

Attachment 373980 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12720592

New failing tests:
media/media-document-audio-repaint.html
fast/text/font-face-local-system.html
media/video-no-audio.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
fast/text/backslash-to-yen-sign-euc.html
fast/text/system-font-features.html
media/controls-after-reload.html

[EWS Watchlist]

Created attachment 373989 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 373980 [details]
Patch

Attachment 373980 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12720632

New failing tests:
fast/text/font-face-local-system.html
media/video-no-audio.html
media/video-volume-slider.html
media/video-display-toggle.html
fast/text/backslash-to-yen-sign-euc.html
fast/text/system-font-features.html
media/controls-after-reload.html

[EWS Watchlist]

Created attachment 373990 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 373980 [details]
Patch

Attachment 373980 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12720654

New failing tests:
media/media-document-audio-repaint.html
fast/text/font-face-local-system.html
media/video-no-audio.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
fast/text/backslash-to-yen-sign-euc.html
fast/text/system-font-features.html
media/controls-after-reload.html

[EWS Watchlist]

Created attachment 373994 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Myles C. Maxfield]

I think this is done c.c

[Myles C. Maxfield]

This is done.