Summary: | A newly inserted element doesn't get assigned to a named slot if slot assignments had already happened | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Guan-tin Chien [:timdream] <timdream> | ||||||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dbates, emilio, esprehn+autocc, ews-watchlist, jochen.kuehner, kangil.han, koivisto, rniwa, simon.strandman, timdream, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Safari Technology Preview | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 148695 | ||||||||||||
Attachments: |
|
Created attachment 373978 [details]
test2.html
The 2nd named slot is also broken without step 4 and 5.
Created attachment 374018 [details]
test3-workaround.html
Apparently removing and re-inserting the element can wake it up.
Created attachment 380190 [details]
Fixes the bug
Comment on attachment 380190 [details]
Fixes the bug
Thanks for the reviews!
Comment on attachment 380190 [details] Fixes the bug Clearing flags on attachment: 380190 Committed r250709: <https://trac.webkit.org/changeset/250709> All reviewed patches have been landed. Closing bug. *** Bug 196347 has been marked as a duplicate of this bug. *** *** Bug 204559 has been marked as a duplicate of this bug. *** |
Created attachment 373973 [details] test.html STR: See test case. There is a while loop does the following twice. 1) append an element to the host and assign a slot name. The slot name is different on each run. 2) create a named slot and append it to the shadow root. 3) assert that the element created is assigned to the slot. 4) remove the element 5) remove the slot Expected: The element should be assigned to the slot correctly on both run. Actual: On the second run the element is not assigned to the slot.