Bug 199640

Summary: Move AutofillElements.{h,cpp} from editing/ios to editing/cocoa since they're used on macOS
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ryanhaddad, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Alex Christensen
Reported 2019-07-09 14:21:05 PDT
Move AutofillElements.{h,cpp} from editing/ios to editing/cocoa since they're used on macOS
Attachments
Patch (24.32 KB, patch)
2019-07-09 14:21 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-07-09 14:21:46 PDT
Created attachment 373765 [details] Patch
Alex Christensen
Comment 2 2019-07-09 14:30:17 PDT
http://trac.webkit.org/r247279
Radar WebKit Bug Importer
Comment 3 2019-07-09 14:33:40 PDT
<rdar://problem/52853105>
Ryan Haddad
Comment 4 2019-07-09 14:56:15 PDT
This broke the build: /Volumes/Data/slave/mojave-release/build/Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:55:9: fatal error: 'WebCore/AutofillElements.h' file not found #import <WebCore/AutofillElements.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. https://build.webkit.org/builders/Apple%20Mojave%20Release%20%28Build%29/builds/6818/steps/compile-webkit/logs/stdio
Alex Christensen
Comment 5 2019-07-09 15:11:19 PDT
http://trac.webkit.org/r247282
Note You need to log in before you can comment on or make changes to this bug.