Bug 199638
| Summary: | Stop checking WeakPtr on background thread in SourceBufferPrivateAVFObjC::enqueueSample() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | achristensen, eric.carlson, jer.noble, youennf |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 199517 | ||
Chris Dumez
Stop checking WeakPtr on background thread in SourceBufferPrivateAVFObjC::enqueueSample():
Thread 14 Crashed:: Dispatch queue: AVSampleBufferDisplayLayerQueueForCallingPrerollCompleteCallback
0 com.apple.JavaScriptCore 0x000000032f84146e WTFCrash + 14 (Assertions.cpp:305)
1 com.apple.WebCore 0x000000031800973b WTFCrashWithInfo(int, char const*, char const*, int) + 27
2 com.apple.WebCore 0x000000031801c7ec WTF::WeakPtrImpl::operator bool() const + 140 (WeakPtr.h:71)
3 com.apple.WebCore 0x000000031838971e WTF::WeakPtr<WebCore::SourceBufferPrivateAVFObjC>::operator bool() const + 62 (WeakPtr.h:98)
4 com.apple.WebCore 0x0000000318395d10 WebCore::SourceBufferPrivateAVFObjC::enqueueSample(WTF::Ref<WebCore::MediaSample, WTF::DumbPtrTraits<WebCore::MediaSample> >&&, WTF::AtomString const&)::$_15::operator()(signed char) + 48 (SourceBufferPrivateAVFObjC.mm:1143)
5 com.apple.WebCore 0x0000000318395cd3 invocation function for block in WebCore::SourceBufferPrivateAVFObjC::enqueueSample(WTF::Ref<WebCore::MediaSample, WTF::DumbPtrTraits<WebCore::MediaSample> >&&, WTF::AtomString const&) + 35 (SourceBufferPrivateAVFObjC.mm:1142)
6 com.apple.avfoundation 0x00007fff31e8a7d9 __164-[AVSampleBufferDisplayLayer(AVSampleBufferDisplayLayerQueueManagement) _callOldPrerollCompletionHandlerWithSuccess:andSetNewPrerollCompletionHandler:forRequestID:]_block_invoke.326 + 28
7 libdispatch.dylib 0x00007fff6dad9683 _dispatch_call_block_and_release + 12
8 libdispatch.dylib 0x00007fff6dada60e _dispatch_client_callout + 8
9 libdispatch.dylib 0x00007fff6dadfbd2 _dispatch_lane_serial_drain + 597
10 libdispatch.dylib 0x00007fff6dae0556 _dispatch_lane_invoke + 363
11 libdispatch.dylib 0x00007fff6dae9bc5 _dispatch_workloop_worker_thread + 582
12 libsystem_pthread.dylib 0x00007fff6dd33860 _pthread_wqthread + 336
13 libsystem_pthread.dylib 0x00007fff6dd3369b start_wqthread + 15
This is a WeakPtr for a main thread object so we should only be using the WeakPtr on the main thread.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |