Summary: | Fix non thread-safe use of WeakPtr in DisplayRefreshMonitorMac::displayLinkFired() | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ews-watchlist, ggaren, rniwa, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 199517 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2019-07-09 10:49:21 PDT
Created attachment 373731 [details]
Patch
Attachment 373731 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373731&action=review Maybe we need ThreadSafeWeakPtr... > Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.h:46 > void displayLinkFired() override; This does class need to inherit from CanMakeWeakPtr now? (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 373731 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373731&action=review > > Maybe we need ThreadSafeWeakPtr... > > > Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.h:46 > > void displayLinkFired() override; > > This does class need to inherit from CanMakeWeakPtr now? Oh, it likely doesn't. Good catch. Created attachment 373733 [details]
Patch
Attachment 373733 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373733 [details] Patch Attachment 373733 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12699554 Number of test failures exceeded the failure limit. Created attachment 373736 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 373737 [details]
Patch
Attachment 373737 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:33: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp:112: More than one command on the same line [whitespace/newline] [4]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 373737 [details] Patch Clearing flags on attachment: 373737 Committed r247273: <https://trac.webkit.org/changeset/247273> All reviewed patches have been landed. Closing bug. |