Bug 199604

Summary: [WHLSL] Import 23 new JS reference spec tests
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199595    
Attachments:
Description Flags
patch
mmaxfield: review+, saam: commit-queue-
patch for landing
saam: commit-queue-
patch for landing
none
patch for landing none

Description Saam Barati 2019-07-08 18:39:39 PDT
...
Comment 1 Saam Barati 2019-07-08 18:48:12 PDT
Created attachment 373689 [details]
patch
Comment 2 Saam Barati 2019-07-08 19:01:02 PDT
I broke some stuff
Comment 3 Saam Barati 2019-07-08 19:12:04 PDT
Comment on attachment 373689 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373689&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:51
> -        Visitor::visit(functionDefinition);
> +        checkErrorAndVisit(functionDefinition);

This should have stayed Visitor::visit

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:61
> -        Visitor::visit(callExpression.function());
> +        checkErrorAndVisit(callExpression);

ditto
Comment 4 Saam Barati 2019-07-08 19:14:32 PDT
Created attachment 373692 [details]
patch for landing
Comment 5 Saam Barati 2019-07-08 19:31:28 PDT
Created attachment 373694 [details]
patch for landing
Comment 6 Saam Barati 2019-07-08 19:38:00 PDT
Created attachment 373695 [details]
patch for landing

fix duplicate JS function errors.
Comment 7 WebKit Commit Bot 2019-07-08 22:32:33 PDT
Comment on attachment 373695 [details]
patch for landing

Clearing flags on attachment: 373695

Committed r247254: <https://trac.webkit.org/changeset/247254>
Comment 8 WebKit Commit Bot 2019-07-08 22:32:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-07-08 22:34:29 PDT
<rdar://problem/52816061>