Summary: | [WHLSL] Import 23 new JS reference spec tests | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||
Component: | WebGPU | Assignee: | Saam Barati <saam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 199595 | ||||||||||||
Attachments: |
|
Description
Saam Barati
2019-07-08 18:39:39 PDT
Created attachment 373689 [details]
patch
I broke some stuff Comment on attachment 373689 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=373689&action=review > Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:51 > - Visitor::visit(functionDefinition); > + checkErrorAndVisit(functionDefinition); This should have stayed Visitor::visit > Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:61 > - Visitor::visit(callExpression.function()); > + checkErrorAndVisit(callExpression); ditto Created attachment 373692 [details]
patch for landing
Created attachment 373694 [details]
patch for landing
Created attachment 373695 [details]
patch for landing
fix duplicate JS function errors.
Comment on attachment 373695 [details] patch for landing Clearing flags on attachment: 373695 Committed r247254: <https://trac.webkit.org/changeset/247254> All reviewed patches have been landed. Closing bug. |