Bug 199598

Summary:

UserData::decode should return false when decoding an unrecognized type

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Description Alex Christensen 2019-07-08 16:02:30 PDT

UserData::decode should return false when decoding an unrecognized type

Comment 1 Alex Christensen 2019-07-08 16:02:53 PDT

Created attachment 373677 [details]
Patch

Comment 2 Ryosuke Niwa 2019-07-08 19:50:28 PDT

Comment on attachment 373677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373677&action=review

> Source/WebKit/Shared/UserData.cpp:601
>          ASSERT_NOT_REACHED();
> +        return false;

I'm a bit surprised that we're not already getting a compiler warning / error about this...

Comment 3 Alex Christensen 2019-07-09 11:27:35 PDT

http://trac.webkit.org/r247263

Comment 4 Radar WebKit Bug Importer 2019-07-09 11:28:23 PDT

<rdar://problem/52843696>