| Summary: | Layers visualization should show layer contents | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | Web Inspector | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, pangle, ross.kirsling, saam, simon.fraser, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2019-07-06 10:36:18 PDT
Created attachment 373615 [details]
Non-working patch
I could not get the material texture stuff to work. Created attachment 373818 [details]
Kinda working patch
Comment on attachment 373818 [details]
Kinda working patch
This patch actually gets bits onto layers.
Created attachment 431555 [details]
WIP v0.1 - Rebase smfr patch, adjust texture UVs
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. Comment on attachment 431555 [details] WIP v0.1 - Rebase smfr patch, adjust texture UVs View in context: https://bugs.webkit.org/attachment.cgi?id=431555&action=review > Source/JavaScriptCore/inspector/protocol/LayerTree.json:112 > + "name": "imageForLayerContents", Rather than having a separate command (which means we'd have a new call-and-response for each layer), I wonder if it'd be better to instead include a `{ "name": "content", "type": "string", "optional": true }` property inside `LayerTree.Layer` and have a `{ "name": "includeContent", "type": "boolean", "optional": true }` parameter for `LayerTree.layersForNode` so that we can instead just have a single command that has all the response in it. I think there also may be a benefit of having a checkbox in the Layers Tab that controls whether image data is fetched (probably default enabled). At least in the short term while evaluating the performance of this. > Source/WebCore/inspector/agents/InspectorLayerTreeAgent.cpp:348 > + return snapshot->toDataURL("image/png"_s, std::nullopt, PreserveResolution::Yes); I wonder if we should consider lowering the `quality`. Maybe only if the performance is really bad. > Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:297 > + layerGroup.add(this._createLayerMesh(layer.compositedBounds), this._createLayerMesh(layer.compositedBounds, true)); o_0 why? |