Bug 199533

Summary: ArgumentsEliminationPhase::eliminateCandidatesThatInterfere() should not decrement nodeIndex pass zero.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, justin_michaud, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. fpizlo: review+

Mark Lam
Reported 2019-07-05 15:00:20 PDT
This is a regression introduced in r246075.
Attachments
proposed patch. (4.40 KB, patch)
2019-07-05 15:16 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-07-05 15:00:52 PDT
<rdar://problem/52669111>
Mark Lam
Comment 2 2019-07-05 15:16:24 PDT
Created attachment 373545 [details] proposed patch.
Mark Lam
Comment 3 2019-07-05 16:06:27 PDT
Thanks for the review. Landed in r247183: <http://trac.webkit.org/r247183>.
Saam Barati
Comment 4 2019-07-05 17:28:42 PDT
Comment on attachment 373545 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=373545&action=review > Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp:610 > + // yet to be processed. Inside the look, it refers to the index Look => loop
Note You need to log in before you can comment on or make changes to this bug.