Bug 199533

Summary:

ArgumentsEliminationPhase::eliminateCandidatesThatInterfere() should not decrement nodeIndex pass zero.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, justin_michaud, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	fpizlo: review+

Description Mark Lam 2019-07-05 15:00:20 PDT

This is a regression introduced in r246075.

Comment 1 Mark Lam 2019-07-05 15:00:52 PDT

<rdar://problem/52669111>

Comment 2 Mark Lam 2019-07-05 15:16:24 PDT

Created attachment 373545 [details]
proposed patch.

Comment 3 Mark Lam 2019-07-05 16:06:27 PDT

Thanks for the review.  Landed in r247183: <http://trac.webkit.org/r247183>.

Comment 4 Saam Barati 2019-07-05 17:28:42 PDT

Comment on attachment 373545 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=373545&action=review

> Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp:610
> +                        // yet to be processed. Inside the look, it refers to the index

Look => loop