Bug 199523

Summary:

WKObject's minimum object alignment needs to be larger

Product:

WebKit

Reporter:

Saagar Jha <saagarjha>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, andersca, beidson, cdumez, commit-queue, ggaren, hysu, mitz, sam, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Mac

OS:

Other

Bug Depends on:

Bug Blocks:

179518

Attachments:

Description	Flags
Patch	none

Description Saagar Jha 2019-07-05 11:51:48 PDT

Got a warning when working on something unrelated: apparently some of the objects we wrap with WKObject require 16-byte alignment on my system (such as WebFrameProxy) but we are running its constructor on an 8-byte aligned address. I believe that changing minimumObjectAlignment to 16 should cover everything that we use, but I have a patch with something that's IMO more portable than a hardcoded number that I'll attach as soon as I can get around to it.

Comment 1 Saagar Jha 2019-07-05 16:26:37 PDT

Created attachment 373552 [details]
Patch

Comment 2 Chris Dumez 2019-07-08 15:24:56 PDT

Looks like Tim Horton did this in Bug 179518.

Comment 3 Tim Horton 2019-07-08 15:32:23 PDT

Oh dear. That was watch bringup, my memory is not great.

Comment 4 WebKit Commit Bot 2019-07-09 14:49:27 PDT

Comment on attachment 373552 [details]
Patch

Clearing flags on attachment: 373552

Committed r247281: <https://trac.webkit.org/changeset/247281>

Comment 5 WebKit Commit Bot 2019-07-09 14:49:29 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2019-07-09 14:54:52 PDT

<rdar://problem/52853984>