Bug 199516

Summary: Add threading assertion to WTF::CompletionHandler
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, Hironori.Fujii, kangil.han, mcatanzaro, rniwa, webkit-bug-importer, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186171
Attachments:
Description Flags
WIP Patch
none
WIP Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews102 for mac-highsierra
none
Archive of layout-test-results from ews107 for mac-highsierra-wk2
none
Archive of layout-test-results from ews112 for mac-highsierra
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Archive of layout-test-results from ews211 for win-future
none
Archive of layout-test-results from ews210 for win-future
none
WIP Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-07-05 08:20:46 PDT
Add threading assertion to WTF::CompletionHandler to make sure it is constructed and called on the same thread.
Attachments
WIP Patch (993 bytes, patch)
2019-07-05 08:21 PDT, Chris Dumez
no flags
WIP Patch (1.08 KB, patch)
2019-07-05 08:37 PDT, Chris Dumez
ews-watchlist: commit-queue-
Archive of layout-test-results from ews102 for mac-highsierra (3.67 MB, application/zip)
2019-07-05 09:52 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (3.37 MB, application/zip)
2019-07-05 10:10 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews112 for mac-highsierra (3.55 MB, application/zip)
2019-07-05 10:42 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews121 for ios-simulator-wk2 (3.22 MB, application/zip)
2019-07-05 10:56 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews211 for win-future (13.45 MB, application/zip)
2019-07-05 13:07 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews210 for win-future (13.87 MB, application/zip)
2019-07-05 13:48 PDT, EWS Watchlist
no flags
WIP Patch (13.18 KB, patch)
2019-07-05 14:17 PDT, Chris Dumez
no flags
Patch (17.46 KB, patch)
2019-07-05 15:57 PDT, Chris Dumez
no flags
Patch (18.38 KB, patch)
2019-07-08 10:31 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2019-07-05 08:21:22 PDT
Created attachment 373493 [details] WIP Patch
Chris Dumez
Comment 2 2019-07-05 08:37:14 PDT
Created attachment 373497 [details] WIP Patch
EWS Watchlist
Comment 3 2019-07-05 09:52:11 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 4 2019-07-05 09:52:13 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 5 2019-07-05 10:10:22 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 6 2019-07-05 10:10:24 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 7 2019-07-05 10:42:51 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 8 2019-07-05 10:42:53 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 9 2019-07-05 10:56:38 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 10 2019-07-05 10:56:40 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 11 2019-07-05 13:07:39 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 12 2019-07-05 13:07:42 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 13 2019-07-05 13:48:27 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 14 2019-07-05 13:48:30 PDT Comment hidden (obsolete)
Chris Dumez
Comment 15 2019-07-05 14:17:12 PDT
Created attachment 373536 [details] WIP Patch
Chris Dumez
Comment 16 2019-07-05 15:57:10 PDT
Michael Catanzaro
Comment 17 2019-07-07 09:09:05 PDT
As Fujii discovered, this is a duplicate of bug #186171 and we have existing good discussion there, so I recommend using that bug instead. FWIW: I think it's very important to add this assertion, but in the other bug you had found a problem....
Chris Dumez
Comment 18 2019-07-07 09:42:01 PDT
(In reply to Michael Catanzaro from comment #17) > As Fujii discovered, this is a duplicate of bug #186171 and we have existing > good discussion there, so I recommend using that bug instead. > > FWIW: I think it's very important to add this assertion, but in the other > bug you had found a problem.... The check in this patch is less strict and is compatible with work queues.
Chris Dumez
Comment 19 2019-07-07 09:42:50 PDT
(In reply to Michael Catanzaro from comment #17) > As Fujii discovered, this is a duplicate of bug #186171 and we have existing > good discussion there, so I recommend using that bug instead. > > FWIW: I think it's very important to add this assertion, but in the other > bug you had found a problem.... We can dupe the other one to this once it lands (less work).
Alex Christensen
Comment 20 2019-07-08 10:26:06 PDT
Comment on attachment 373549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373549&action=review > Source/WebKit/ChangeLog:11 > + worker thread. Ideally, this code would be refactored so that the callback gets called on > + the worker thread directly. Should we add a FIXME comment? This ChangeLog entry will probably never get looked at again.
Chris Dumez
Comment 21 2019-07-08 10:31:18 PDT
WebKit Commit Bot
Comment 22 2019-07-08 11:26:55 PDT
Comment on attachment 373641 [details] Patch Clearing flags on attachment: 373641 Committed r247218: <https://trac.webkit.org/changeset/247218>
WebKit Commit Bot
Comment 23 2019-07-08 11:26:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.