Bug 199496

Summary: [GTK] Fix browserperfdash script after r239522
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, dewei_zhu, ews, glenn, mcatanzaro, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 192905    
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2019-07-04 06:22:09 PDT
r239522 Added a new --browser-path argument to run-benchmark.
This argument was made as non-optional on the BenchmarkRunner constructor.

The browserperfdash script needs to be updated accordingly as well.
Comment 1 Carlos Alberto Lopez Perez 2019-07-04 06:27:42 PDT
Created attachment 373462 [details]
Patch
Comment 2 Michael Catanzaro 2019-07-04 06:49:09 PDT
Comment on attachment 373462 [details]
Patch

Please investigate the GitHub security warning for this website while you're at it. I requested many months ago for it to be taken offline because nobody was caring for it, but that never happened.
Comment 3 Carlos Alberto Lopez Perez 2019-07-04 06:52:55 PDT
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 373462 [details]
> Patch
> 
> Please investigate the GitHub security warning for this website while you're
> at it. I requested many months ago for it to be taken offline because nobody
> was caring for it, but that never happened.

Sure.

I will take care of it
Comment 4 Carlos Alberto Lopez Perez 2019-07-04 06:53:36 PDT
Comment on attachment 373462 [details]
Patch

Clearing flags on attachment: 373462

Committed r247140: <https://trac.webkit.org/changeset/247140>
Comment 5 Carlos Alberto Lopez Perez 2019-07-04 06:53:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-04 06:54:19 PDT
<rdar://problem/52645195>