Bug 199487

Summary:

JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

Tools / Tests

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bfulgham, don.olmstead, ews-watchlist, glenn, pvollan, ross.kirsling, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=197669
https://bugs.webkit.org/show_bug.cgi?id=188424

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews211 for win-future	none

Fujii Hironori

Reported 2019-07-03 19:16:30 PDT

JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python WinCairo Buildbot is reporting the failure. https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/4426 > FAIL: (JS) JSTestGlobalObject.cpp Seems to happen since Bug 197669. This issue does happen for Cygwin Python.

Attachments
Patch (5.84 KB, patch) 2019-07-04 00:36 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews211 for win-future (14.21 MB, application/zip) 2019-07-04 07:11 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-07-03 19:17:29 PDT

(In reply to Fujii Hironori from comment #0) > This issue does happen for Cygwin Python. does → doesn't

Fujii Hironori

Comment 2 2019-07-03 21:09:48 PDT

In Windows Python, preprocessor.pm calls cl.exe. cl.exe is failing to open testglobalscope_constructors_file which is created by webkitpy/bindings/main.py using tempfile.mkstemp(). > c1: fatal error C1083: Cannot open source file: 'c:/users/000013~1/appdata/local/temp/tmpytx5zj': Permission denied In Cygwin Python, preprocessor.pm is using Cygwin's gcc.

Fujii Hironori

Comment 3 2019-07-04 00:36:05 PDT

Created attachment 373456 [details] Patch

EWS Watchlist

Comment 4 2019-07-04 07:11:32 PDT Comment hidden (obsolete)

Comment on attachment 373456 [details] Patch Attachment 373456 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12660279 New failing tests: svg/text/textpath-reference-update.html js/dom/try-catch-crash.html

EWS Watchlist

Comment 5 2019-07-04 07:11:35 PDT Comment hidden (obsolete)

Created attachment 373464 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Fujii Hironori

Comment 6 2019-07-08 18:04:25 PDT

Comment on attachment 373456 [details] Patch Clearing flags on attachment: 373456 Committed r247244: <https://trac.webkit.org/changeset/247244>

Fujii Hironori

Comment 7 2019-07-08 18:04:29 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-07-08 18:18:16 PDT

<rdar://problem/52808392>

Note You need to log in before you can comment on or make changes to this bug.