Bug 199435 – AX: CrashTracer: com.apple.WebKit.WebContent at WebKit: WebKit::WebSpeechSynthesisClient::speak

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed ↩:
0   WebCore                       	0x000000019a80adc4 non-virtual thunk to WebCore::SpeechSynthesis::didStartSpeaking() + 20 (DumbPtrTraits.h:43)
1   WebKit                        	0x0000000199ae8ab8 WebKit::WebSpeechSynthesisClient::speak(WTF::RefPtr<WebCore::PlatformSpeechSynthesisUtterance, WTF::DumbPtrTraits<WebCore::PlatformSpeechSynthesisUtterance> >) + 424 (WebSpeechSynthesisClient.cpp:69)
2   WebCore                       	0x000000019a80a49c WebCore::SpeechSynthesis::startSpeakingImmediately(WebCore::SpeechSynthesisUtterance&) + 124 (SpeechSynthesis.cpp:125)
3   WebCore                       	0x000000019a4b7064 WebCore::jsSpeechSynthesisPrototypeFunctionSpeakBody(JSC::ExecState*, WebCore::JSSpeechSynthesis*, JSC::ThrowScope&) + 248 (JSSpeechSynthesis.cpp:202)
4   WebCore                       	0x000000019a4a88a8 WebCore::jsSpeechSynthesisPrototypeFunctionSpeak(JSC::ExecState*) + 152 (JSDOMOperation.h:53)
5   ???                           	0x0000000c038d9098 0 + 51599216792

<rdar://problem/52563665>

[chris fleizach]

Created attachment 373396 [details]
patch

[Per Arne Vollan]

Comment on attachment 373396 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373396&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:57
> +        if (auto observer = m_page.corePage()->speechSynthesisClient()->observer())
> +            observer->didFinishSpeaking();

Could speechSynthesisClient() also possibly return nullptr?

[chris fleizach]

(In reply to Per Arne Vollan from comment #2)
> Comment on attachment 373396 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373396&action=review
> 
> > Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:57
> > +        if (auto observer = m_page.corePage()->speechSynthesisClient()->observer())
> > +            observer->didFinishSpeaking();
> 
> Could speechSynthesisClient() also possibly return nullptr?

I looked into it and to my eyes it did not seem so. It looks like it's set unconditionally

[Per Arne Vollan]

Comment on attachment 373396 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373396&action=review

>>> Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:57
>>> +            observer->didFinishSpeaking();
>> 
>> Could speechSynthesisClient() also possibly return nullptr?
> 
> I looked into it and to my eyes it did not seem so. It looks like it's set unconditionally

Perhaps it could return a reference, then? I don't think this is required in this patch, though. It can be done in a follow-up patch.

[chris fleizach]

Comment on attachment 373396 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373396&action=review

>>>> Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:57
>>>> +            observer->didFinishSpeaking();
>>> 
>>> Could speechSynthesisClient() also possibly return nullptr?
>> 
>> I looked into it and to my eyes it did not seem so. It looks like it's set unconditionally
> 
> Perhaps it could return a reference, then? I don't think this is required in this patch, though. It can be done in a follow-up patch.

let me look into that

[Ryosuke Niwa]

Comment on attachment 373396 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373396&action=review

>>>>> Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:57
>>>>> +            observer->didFinishSpeaking();
>>>> 
>>>> Could speechSynthesisClient() also possibly return nullptr?
>>> 
>>> I looked into it and to my eyes it did not seem so. It looks like it's set unconditionally
>> 
>> Perhaps it could return a reference, then? I don't think this is required in this patch, though. It can be done in a follow-up patch.
> 
> let me look into that

m_speechSynthesisClient(WTFMove(pageConfiguration.speechSynthesisClient)) so if pageConfiguration.speechSynthesisClient is null, it could be null.
I think we should add an extra null check for now. We can turn it to a reference in the future.

[Ryosuke Niwa]

r=me with an extra null check for speechSynthesisClient() everywhere.

[chris fleizach]

Created attachment 373557 [details]
patch

[WebKit Commit Bot]

Comment on attachment 373557 [details]
patch

Clearing flags on attachment: 373557

Committed r247192: <https://trac.webkit.org/changeset/247192>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.