Bug 199430 – REGRESSION (iOS 13): Tapping an element with a click event handler no longer clears the selection

• Component: HTML Editing
• Status: RESOLVED FIXED

[Wenson Hsieh]

This makes it nearly impossible to truly dismiss a text selection on a New York Times article, Google search results page, and other big websites. I wrote “truly dismiss” because while it looks like the UIKit selection view disappears upon tapping, the DOM selection remains the same.

To reproduce:

1. Go to any New York Times article.
2. Make a text selection.
3. Try to dismiss the text selection by tapping on some other text. Notice that the blue tinted selection view disappears.
4. Open Web Inspector and type “getSelection().toString()”.

Expected: Empty string.
Observed: The originally selected text.

[Wenson Hsieh]

Created attachment 373390 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/52589498>

[Tim Horton]

Comment on attachment 373390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373390&action=review

> Source/WebCore/ChangeLog:8
> +        After <trac.webkit.org/r245067>, we no longer immediately clear the text selection when recognizing a single tap

Whoops

> Source/WebCore/ChangeLog:24
> +        breaking the fix in r233311 by matching macOS behavior and not bailing via early return in the case where the

Very nice!

[WebKit Commit Bot]

Comment on attachment 373390 [details]
Patch

Clearing flags on attachment: 373390

Committed r247100: <https://trac.webkit.org/changeset/247100>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.