Bug 199423 – Make sure to cross-thread copy in StorageManager when hopping back to the main thread

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[youenn fablet]

Make sure to cross-thread copy in StorageManager when hopping back to the main thread

[youenn fablet]

Created attachment 373364 [details]
Patch

[youenn fablet]

Created attachment 373367 [details]
Patch

[Chris Dumez]

Comment on attachment 373367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373367&action=review

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:132
> +Vector<LocalStorageDatabaseTracker::OriginDetails> LocalStorageDatabaseTracker::originDetailsIsolatedCopy()

What's getting isolatedCopied here? It is not obvious to me from looking at the implementation.

[youenn fablet]

Comment on attachment 373367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373367&action=review

>> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:132
>> +Vector<LocalStorageDatabaseTracker::OriginDetails> LocalStorageDatabaseTracker::originDetailsIsolatedCopy()
> 
> What's getting isolatedCopied here? It is not obvious to me from looking at the implementation.

There is nothing getting copied but I want to make it clear that this method is generating already isolated strings here.
Initially, when reading the code, I thought there might be an issue and was thinking of isolating-copy at call site.
Maybe another name might be better or adding an ASSERT at call site?

[Chris Dumez]

Comment on attachment 373367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373367&action=review

>>> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:132
>>> +Vector<LocalStorageDatabaseTracker::OriginDetails> LocalStorageDatabaseTracker::originDetailsIsolatedCopy()
>> 
>> What's getting isolatedCopied here? It is not obvious to me from looking at the implementation.
> 
> There is nothing getting copied but I want to make it clear that this method is generating already isolated strings here.
> Initially, when reading the code, I thought there might be an issue and was thinking of isolating-copy at call site.
> Maybe another name might be better or adding an ASSERT at call site?

Why not isolateCopy() at call site? Nothing guarantees that origin.databaseIdentifier() returns a String that is isolated. It might be safe now but no guarantee that origin.databaseIdentifier() does not get updated in the future.

[youenn fablet]

(In reply to Chris Dumez from comment #5)
> Comment on attachment 373367 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373367&action=review
> 
> >>> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:132
> >>> +Vector<LocalStorageDatabaseTracker::OriginDetails> LocalStorageDatabaseTracker::originDetailsIsolatedCopy()
> >> 
> >> What's getting isolatedCopied here? It is not obvious to me from looking at the implementation.
> > 
> > There is nothing getting copied but I want to make it clear that this method is generating already isolated strings here.
> > Initially, when reading the code, I thought there might be an issue and was thinking of isolating-copy at call site.
> > Maybe another name might be better or adding an ASSERT at call site?
> 
> Why not isolateCopy() at call site? Nothing guarantees that
> origin.databaseIdentifier() returns a String that is isolated. It might be
> safe now but no guarantee that origin.databaseIdentifier() does not get
> updated in the future.

Yeah, this should not be called that often so let's do it.

[youenn fablet]

Created attachment 373372 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 373372 [details]
Patch

Clearing flags on attachment: 373372

Committed r247092: <https://trac.webkit.org/changeset/247092>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52596472>