Bug 199412

Summary: Simplify logic that handles registering WebProcessProxy objects with their WebsiteDataStore
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ews-watchlist, ggaren, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 199407    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews211 for win-future none

Chris Dumez
Reported 2019-07-02 11:25:40 PDT
Simplify logic that handles registering WebProcessProxy objects with their WebsiteDataStore to make it more maintainable and less error-prone.
Attachments
Patch (40.43 KB, patch)
2019-07-02 11:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (40.65 KB, patch)
2019-07-02 11:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (40.64 KB, patch)
2019-07-02 13:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (40.71 KB, patch)
2019-07-02 14:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (13.90 MB, application/zip)
2019-07-02 18:52 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-07-02 11:25:58 PDT
<rdar://problem/51899751>
Chris Dumez
Comment 2 2019-07-02 11:46:04 PDT
Created attachment 373347 [details] Patch
Chris Dumez
Comment 3 2019-07-02 11:48:51 PDT
Created attachment 373348 [details] Patch
Chris Dumez
Comment 4 2019-07-02 13:54:30 PDT
Created attachment 373358 [details] Patch
Chris Dumez
Comment 5 2019-07-02 14:54:01 PDT
Created attachment 373363 [details] Patch
EWS Watchlist
Comment 6 2019-07-02 18:52:35 PDT
Comment on attachment 373363 [details] Patch Attachment 373363 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12646243 New failing tests: css3/filters/blur-various-radii.html
EWS Watchlist
Comment 7 2019-07-02 18:52:38 PDT
Created attachment 373376 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Chris Dumez
Comment 8 2019-07-03 08:10:20 PDT
(In reply to Build Bot from comment #6) > Comment on attachment 373363 [details] > Patch > > Attachment 373363 [details] did not pass win-ews (win): > Output: https://webkit-queues.webkit.org/results/12646243 > > New failing tests: > css3/filters/blur-various-radii.html This does not seem related to my change, the patch is ready for review.
Chris Dumez
Comment 9 2019-07-03 15:30:25 PDT
ping review?
Ryosuke Niwa
Comment 10 2019-07-03 20:17:23 PDT
Comment on attachment 373363 [details] Patch The change looks good but I hope Brady or Alex could have a second look at it.
WebKit Commit Bot
Comment 11 2019-07-04 16:53:27 PDT
Comment on attachment 373363 [details] Patch Clearing flags on attachment: 373363 Committed r247146: <https://trac.webkit.org/changeset/247146>
WebKit Commit Bot
Comment 12 2019-07-04 16:53:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.