Bug 199406 – [GTK][WPE] Not longer needed to build woff2 on the JHBuild

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

On r223042 <https://trac.webkit.org/r223042> we removed Woff2 from ThirdParty and started bundling it on the JHBuild.

Now the 4 distributions we "support" for development have a recent enough version of woff2.

So there is no need to keep building this, we can just use the system one.

I have checked that the woff2 version shipped both on Debian 10 and Ubuntu 18.04 work fine.
And I guess Fedora and Arch should work fine as well.

Both the debian and ubuntu stable bots are using now the system version
Until now they were building with -DUSE_WOFF2=OFF (I removed this config parameter from the bots and installed system woff2)

[Carlos Alberto Lopez Perez]

Created attachment 373331 [details]
Patch

[Aakash Jain]

This patch fails new EWS on WPE:
https://ews-build.webkit-uat.org/#/builders/7/builds/429
Retry: https://ews-build.webkit-uat.org/#/builders/7/builds/438

Not sure how it passed old EWS: https://webkit-queues.webkit.org/patch/373331/wpe-ews

[Michael Catanzaro]

Hey Aakash, it's failing on new EWS because the new EWS isn't running the jhbuild step yet. You just fixed that over in bug #199408.

[Michael Catanzaro]

Comment on attachment 373331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373331&action=review

> Tools/wpe/install-dependencies:93
> -        zlib1g-dev"
> +        zlib1g-dev \
> +        libwoff-dev"

Should be alphabetized under l

[Aakash Jain]

(In reply to Michael Catanzaro from comment #3)
> Hey Aakash, it's failing on new EWS because the new EWS isn't running the jhbuild step yet. You just fixed that over in bug #199408.
jhbuild step was run in the build URLs I posted above. I have already applied my patches to that EWS UAT instance.

[Michael Catanzaro]

(In reply to Aakash Jain from comment #5)
> jhbuild step was run in the build URLs I posted above. I have already
> applied my patches to that EWS UAT instance.

Oh, sorry, my bad: my answer was incorrect because we were only removing libraries from the jhbuild.

We just need to install libbrotli and libwoff on the new EWS. This needs to be done manually on the rare occasions when we add new dependencies (including when we remove them from the jhbuild).

[Michael Catanzaro]

(It passed on the old EWS because the old EWS happen to have these libraries already installed. In the future, if we switch to using containerization software like podman/docker to run the EWS, then we could avoid instance-specific configuration differences like these.)

[Carlos Alberto Lopez Perez]

It seems this patch will broke continuous building when it lands due to:

1) Our JHBuild tooling is smart enough to detect a change on the moduleset has happened so it does a clean build of the JHBuild
2) But our WebKit build tooling doesn't detect the JHBuild has been rebuilt so it just triggers a continous build, and this happens:

-- Build files have been written to: /home/igalia/clopez/webkit/webkit/WebKitBuild/Release
ninja: error: '../DependenciesGTK/Root/lib/libwoff2dec.so', needed by 'lib/libwebkit2gtk-4.0.so.37.38.1', missing and no known rule to make it

The previous binaries are liked with a libwoff2dec.so that is now gone on that path, and that seems to cause a ninja error.

So its needed to trigger a clean build.

[Michael Catanzaro]

Ideally the bots would trigger a clean build (wipe of the build directory) every time the JHBuild is run.

[Carlos Alberto Lopez Perez]

(In reply to Michael Catanzaro from comment #9)
> Ideally the bots would trigger a clean build (wipe of the build directory)
> every time the JHBuild is run.

It seems cleaning the CMake cache is enough to avoid this. Will upload a patch for that in #199449

[Carlos Alberto Lopez Perez]

Committed r247138: <https://trac.webkit.org/changeset/247138>

[Radar WebKit Bug Importer]

<rdar://problem/52639816>