Bug 199366

Summary: [iOS] REGRESSION (r246757): Unable to select non-editable text in subframes
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Wenson Hsieh 2019-07-01 08:15:17 PDT 
To reproduce:

1. Go to https://whsieh.github.io/examples/subframes.
2. Try to select any of the text in the first section (lorem.html) by any of the usual means (long pressing, via tap-and-half, etc.)

Observe that you can’t select any text.
Comment 1 Radar WebKit Bug Importer 2019-07-01 08:19:56 PDT 
<rdar://problem/52460509>
Comment 2 Wenson Hsieh 2019-07-01 08:20:03 PDT 
Appears to be a recent regression in iOS 13.
Comment 3 Wenson Hsieh 2019-07-01 08:39:56 PDT 
Caused by: https://trac.webkit.org/changeset/246757/webkit

That revision also caused several layout tests to consistently fail:

• editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html
• editing/selection/ios/selection-handles-in-iframe.html
• editing/selection/ios/selection-handle-clamping-in-iframe.html
Comment 4 Wenson Hsieh 2019-07-01 13:43:07 PDT 
(In reply to Wenson Hsieh from comment #3)
> Caused by: https://trac.webkit.org/changeset/246757/webkit
> 
> That revision also caused several layout tests to consistently fail:
> 
> •
> editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.
> html

This one’s actually failing for a different reason.

> • editing/selection/ios/selection-handles-in-iframe.html
> • editing/selection/ios/selection-handle-clamping-in-iframe.html
Comment 5 Wenson Hsieh 2019-07-01 13:44:18 PDT 
Created attachment 373253 [details]
Patch
Comment 6 WebKit Commit Bot 2019-07-01 15:10:51 PDT 
Comment on attachment 373253 [details]
Patch

Clearing flags on attachment: 373253

Committed r247027: <https://trac.webkit.org/changeset/247027>
Comment 7 WebKit Commit Bot 2019-07-01 15:10:53 PDT 
All reviewed patches have been landed.  Closing bug.