Bug 199348

Summary: Use separate variables for moving and stationary scrolling relationships in RemoteLayerTreeNode
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: ScrollingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, darin, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
darin: review+
patch
none
patch none

Antti Koivisto
Reported 2019-06-30 00:17:27 PDT
A layer can have only one acting scroll parent. Not using a vector for that case makes the code clearer.
Attachments
patch (11.18 KB, patch)
2019-06-30 00:31 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (17.76 KB, patch)
2019-06-30 12:12 PDT, Antti Koivisto 		darin: review+
DetailsFormatted DiffDiff
patch (17.66 KB, patch)
2019-06-30 21:42 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (17.74 KB, patch)
2019-06-30 22:09 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-06-30 00:31:16 PDT
Created attachment 373190 [details] patch
Antti Koivisto
Comment 2 2019-06-30 12:12:48 PDT
Created attachment 373195 [details] patch
Darin Adler
Comment 3 2019-06-30 13:04:05 PDT
Comment on attachment 373195 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=373195&action=review While I’m not a real expert on this code, this looks good to me. > Source/WebCore/page/scrolling/ScrollingTree.h:187 > + HashSet<RefPtr<ScrollingTreeOverflowScrollProxyNode>> m_activeOverflowScrollProxyNodes; > + HashSet<RefPtr<ScrollingTreePositionedNode>> m_activePositionedNodes; A number of places elsewhere use HashSet<Ref<>> rather than HashSet<RefPtr<>>. Is there a reason to prefer RefPtr here? > Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:134 > + return (WKChildScrollView *)actingParent->uiView(); Not new, but: Would be nice to have a type checking cast like downcast<> here for clarity/assertion. Also unclear to me how solid the guarantee behind this typecast is.
Antti Koivisto
Comment 4 2019-06-30 21:42:07 PDT
Created attachment 373210 [details] patch
Antti Koivisto
Comment 5 2019-06-30 22:09:05 PDT
Created attachment 373211 [details] patch
Antti Koivisto
Comment 6 2019-06-30 22:09:38 PDT
> A number of places elsewhere use HashSet<Ref<>> rather than > HashSet<RefPtr<>>. Is there a reason to prefer RefPtr here? No reason, I just didn't remember it works.
WebKit Commit Bot
Comment 7 2019-06-30 22:52:37 PDT
Comment on attachment 373211 [details] patch Clearing flags on attachment: 373211 Committed r246962: <https://trac.webkit.org/changeset/246962>
WebKit Commit Bot
Comment 8 2019-06-30 22:52:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-06-30 22:53:20 PDT
<rdar://problem/52441382>
Note You need to log in before you can comment on or make changes to this bug.